feat(tools): add question tool with inline editor

[taciturnaxolotl]

This builds on the excellent work in #2980 and #2579 to implement an ask-question tool in a few different forms:

• Binary (Yes/No)
• Multiple options, single choice
• Multiple choice
• Question series

Co-authored by: @vadiminshakov
Co-authored by: @detro

fixes CHARM-1423

[dcu]

crush tends to not ask questions because of the system prompt, what do you think of adjusting it?

[taciturnaxolotl]

thats not a bad idea; personally i haven't noticed a huge lack of asking questions in my testing if you are seeing it more then that might be a good idea

[taciturnaxolotl]

for example it just prompted me with a question while editing my jj config

[vadiminshakov]

Questions shouldn’t be asked too often, otherwise it will become annoying for the user. Right now, the frequency of questions seems fine to me

[dcu]

in my experience it sometimes overthinks and keeps in a loop instead of asking question, sometimes I just have to stop and tell the agent to ask me questions and then it can move on. this is specially true with kimi k2.6

[taciturnaxolotl]

yeah that is a bit of a problem with kimi; it doesn't happen as much with other models in my experience. Either disabling thinking or setting reasoning level to low on kimi usually works pretty well for me

[vadiminshakov]

Everything seems to be working well. You can clean up the extra interface (BatchService iface), but overall this shouldn’t block the merge

[meowgorithm]

@taciturnaxolotl perhaps we should rethink how the controller is setup. The comments and number of args here is a code smell to me. That is to say, the arguments may be better as a struct so the values are self documenting.

[taciturnaxolotl]

i agree; i was wanting to change it but didn't want to break anything in this pr

[taciturnaxolotl]

added a new commit for this