fix(shell): isolate child processes from Crush's session#3097
Open
taciturnaxolotl wants to merge 1 commit into
Open
fix(shell): isolate child processes from Crush's session#3097taciturnaxolotl wants to merge 1 commit into
taciturnaxolotl wants to merge 1 commit into
Conversation
taciturnaxolotl
force-pushed
the
process-isolation
branch
4 times, most recently
from
b591ecd to
38b790d
Compare
terminal Child processes spawned by the shell interpreter shared Crush's session, allowing shells like zsh to grab the TTY for job control. This caused "suspended (tty input)" hangs and corrupted Bubble Tea's rendering via unexpected escape sequences. Replace mvdan's DefaultExecHandler with a process-isolated variant that sets Setsid on Unix, and target signals at the child's process group so grandchildren are cleaned up on cancellation.
taciturnaxolotl
force-pushed
the
process-isolation
branch
from
38b790d to
18b65f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child processes spawned by the shell interpreter shared Crush's session, allowing shells like zsh to grab the TTY for job control. This caused "suspended (tty input)" hangs and corrupted Bubble Tea's rendering via unexpected escape sequences. Replace mvdan's DefaultExecHandler with a process-isolated variant that sets Setsid on Unix, and target signals at the child's process group so grandchildren are cleaned up on cancellation.
you can test this by running an interactive program with zsh interactive mode:
zsh -i -c 'crush'