fix: support pasting WeChat screenshots on macOS#3137
Open
jialudev wants to merge 1 commit into
Open
Conversation
WeChat screenshots are copied to the clipboard as TIFF, but go-nativeclipboard only reads NSPasteboardTypePNG on macOS. This caused Ctrl+V to silently fail for those images. Add a macOS-specific fallback that reads NSPasteboardTypeTIFF and converts it to PNG before attaching it to the message. Fixes charmbracelet#3136
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA. |
Author
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS, pasting a WeChat screenshot (微信截图) into Crush with
Ctrl+Vsilently fails, while copying an image file and pasting it works.Root cause
go-nativeclipboardreads clipboard images on macOS using onlyNSPasteboardTypePNG. WeChat screenshots are copied asNSPasteboardTypeTIFF, so the library returnsErrUnavailableand Crush falls back to reading text from the clipboard.Fix
Add a macOS-specific fallback that reads
NSPasteboardTypeTIFFfrom the pasteboard and converts it to PNG before creating the attachment. Non-macOS platforms keep the existing behavior.Related
Fixes #3136