fix(gemini): preserve per-tool-call thought signatures#3140
Open
macro-ss wants to merge 1 commit into
Open
Conversation
Gemini 3 thinking models attach a thoughtSignature to each function-call
part that must be replayed verbatim on that specific part. crush stored a
single ReasoningContent per assistant message and concatenated every
signature into one string (AppendThoughtSignature), losing per-call
association. On replay ToAIMessage sent the concatenated blob as one
signature, so Gemini rejected the request with 'Corrupted thought
signature'. The corrupted signature was persisted, poisoning the whole
session and recurring across restarts.
- message.ToolCall: add ThoughtSignature field; preserve it in
FinishToolCall/AppendToolCallInput; add SetToolCallThoughtSignature
- stop reasoning mutators (FinishThinking, AppendReasoningContent,
SetReasoningResponsesData) from silently dropping signature fields
- ToAIMessage: emit each signature in its own ReasoningPart immediately
before its text/tool-call part instead of concatenating
- agent: buffer per-toolID signatures in OnReasoningEnd and attach them
to the matching tool call in OnToolCall
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your submission. We really appreciate it! Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request comment same as the below format. I have read the Contributor License Agreement (CLA) and hereby sign the CLA. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
bugfix for the same issue: #1698 |
Author
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemini 3 thinking models attach a thoughtSignature to each function-call
part that must be replayed verbatim on that specific part. crush stored a
single ReasoningContent per assistant message and concatenated every
signature into one string (AppendThoughtSignature), losing per-call
association. On replay ToAIMessage sent the concatenated blob as one
signature, so Gemini rejected the request with 'Corrupted thought
signature'. The corrupted signature was persisted, poisoning the whole
session and recurring across restarts.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
CONTRIBUTING.md.