Skip to content

fix(providers/google): omit function call ID for vertex ai to prevent error 400 #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eswar-7116 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(providers/google): omit function call ID for vertex ai to prevent error 400 #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b48c0fd
fix(providers/google): omit function call IDs for Vertex AI to preven…
eswar-7116 Jun 9, 2026
3311f59
test(providertests): manually strip IDs from Vertex VCR cassettes to …
eswar-7116 Jun 9, 2026
5776c4b
Apply suggestions from code review
eswar-7116 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 30 additions & 12 deletions providers/google/google.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,8 @@ func (g languageModel) prepareParams(call fantasy.Call) (*genai.GenerateContentC
}
}

systemInstructions, content, warnings := toGooglePrompt(call.Prompt)
isVertexAI := g.providerOptions.backend == genai.BackendVertexAI
systemInstructions, content, warnings := toGooglePrompt(call.Prompt, isVertexAI)

if providerOptions.ThinkingConfig != nil {
if providerOptions.ThinkingConfig.IncludeThoughts != nil &&
Expand Down Expand Up @@ -347,7 +348,7 @@ func (g languageModel) prepareParams(call fantasy.Call) (*genai.GenerateContentC
return config, content, warnings, nil
}

func toGooglePrompt(prompt fantasy.Prompt) (*genai.Content, []*genai.Content, []fantasy.CallWarning) { //nolint: unparam
func toGooglePrompt(prompt fantasy.Prompt, isVertexAI bool) (*genai.Content, []*genai.Content, []fantasy.CallWarning) { //nolint: unparam
var systemInstructions *genai.Content
var content []*genai.Content
var warnings []fantasy.CallWarning
Expand Down Expand Up @@ -462,6 +463,11 @@ func toGooglePrompt(prompt fantasy.Prompt) (*genai.Content, []*genai.Content, []
Args: result,
},
}

// Vertex breaks with a 400 if this field be present.
if isVertexAI {
geminiPart.FunctionCall.ID = ""
}

@andreynering andreynering Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
geminiPart := &genai.Part{
FunctionCall: &genai.FunctionCall{
ID: toolCall.ToolCallID,
Name: toolCall.ToolName,
Args: result,
},
}
// Vertex breaks with a 400 if this field be present.
if isVertexAI {
geminiPart.FunctionCall.ID = ""
}
}

if currentReasoningMetadata != nil {
geminiPart.ThoughtSignature = []byte(currentReasoningMetadata.Signature)
currentReasoningMetadata = nil
Expand Down Expand Up @@ -506,12 +512,18 @@ func toGooglePrompt(prompt fantasy.Prompt) (*genai.Content, []*genai.Content, []
continue
}
response := map[string]any{"result": content.Text}
functionResponse := &genai.FunctionResponse{
ID: result.ToolCallID,
Response: response,
Name: toolCall.ToolName,
}

// Vertex breaks with a 400 if this field be present.
if isVertexAI {
functionResponse.ID = ""
}
parts = append(parts, &genai.Part{
FunctionResponse: &genai.FunctionResponse{
ID: result.ToolCallID,
Response: response,
Name: toolCall.ToolName,
},
FunctionResponse: functionResponse,
})

case fantasy.ToolResultContentTypeError:
Expand All @@ -520,12 +532,18 @@ func toGooglePrompt(prompt fantasy.Prompt) (*genai.Content, []*genai.Content, []
continue
}
response := map[string]any{"result": content.Error.Error()}
functionResponse := &genai.FunctionResponse{
ID: result.ToolCallID,
Response: response,
Name: toolCall.ToolName,
}

// Vertex breaks with a 400 if this field be present.
if isVertexAI {
functionResponse.ID = ""
}
parts = append(parts, &genai.Part{
FunctionResponse: &genai.FunctionResponse{
ID: result.ToolCallID,
Response: response,
Name: toolCall.ToolName,
},
FunctionResponse: functionResponse,
})
}
}
Expand Down
2 changes: 1 addition & 1 deletion providertests/testdata/TestGoogleCommon/vertex-gemini-2-5-flash/multi_tool.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion providertests/testdata/TestGoogleCommon/vertex-gemini-2-5-flash/multi_tool_streaming.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion providertests/testdata/TestGoogleCommon/vertex-gemini-2-5-flash/tool.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion providertests/testdata/TestGoogleCommon/vertex-gemini-2-5-flash/tool_streaming.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion providertests/testdata/TestGoogleCommon/vertex-gemini-2-5-pro/multi_tool.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading