fix(openai): handle mixed content and tool call stream chunks#279
Draft
slegarraga wants to merge 1 commit into
Draft
fix(openai): handle mixed content and tool call stream chunks#279slegarraga wants to merge 1 commit into
slegarraga wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delta.contentanddelta.tool_calls.Root cause
The chat-completion stream parser used a
switchover delta content vs. tool calls. When an OpenAI-compatible provider emitted both fields in the same chunk, the content branch ran and the tool-call delta was skipped.This matches the downstream failure mode described in charmbracelet/crush#2936, where local OpenAI-compatible providers can return
finish_reason: "tool_calls"with populated streamed tool-call deltas that never reach the agent loop.Validation
go test ./providers/openai -run 'TestDoStream/should handle content and tool call deltas in the same chunk' -count=1go test ./providers/openai -count=1go test ./providers/openaicompat -count=1go test ./... -count=1