fix(vt): clamp scroll margins to screen bounds - #954
Open
trentkm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out-of-range DECSTBM and DECSLRM trailing margins were stored beyond the render buffer. A later reverse-index (
ESC M) passed that rectangle to ultraviolet and panicked while indexing the first cell outside the grid.Clamp bottom and right margins to the current screen dimensions, while preserving the existing handling of one-cell regions at the lower/right edge. Reject leading margins that begin beyond the screen.
This was observed in a live terminal resize and reduces to:
Tests cover both DECSTBM and DECSLRM bounds.
Tested with
go test ./...fromvt/.Downstream report: trentkm/stormlight#199