fix: allow resizing images wrapped in inline links#53
Merged
Conversation
iamsivin
force-pushed
the
fix/image-resize
branch
from
bb092c3 to
5d47e49
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where pasted images could not be resized immediately after being added to the editor. In some cases, pasted images are wrapped inside an inline
<a>element whoseclientWidthis0. Since the resize logic relies on this value, it would exit early and prevent the resize handles from functioning until the editor was reloaded.The fix introduces a fallback to the editor width (
view.dom.clientWidth) whenever the parent element does not provide a valid width, ensuring that image resizing works correctly without requiring a page refresh.