Repository navigation
feat(s16): watched browser inputs and one-press owner cards (slice 3b) - #461
Conversation
[Critical impact] The reviewed change appears safe to merge; fresh CI should confirm the full suite. SummaryAdds watched browser inputs and owner-only action cards. The latest change fixes a weekday-dependent memory test without changing production code.
No new actionable issues found. The four supplied previous findings are addressed in the current code. Tests were not run during this review. Reviews (9) · Last reviewed commit: "test(memory): exclude host date from pri..." · Reviewed by Greptile |
|
@greptileai review Please re-review exact latest head 5bd03c1 (normal push on
Verification at this head: typecheck, upstream provenance and diff checks PASS; focused actions/cards 66 pass / 0 fail; related 13-file regression 303 pass / 2 live skip / 0 fail. Five new regression cases failed before the fixes. A separate exact-head full suite is running at Mono Corrected original-head evidence: the full run at e2137a3 completed 4809 pass / 59 skip / 0 fail, exit 0. This completed baseline is retained separately and the PR body now distinguishes it from the new-head run. Duo -> Tria review cycle resumes at this new head. No merge before latest-head CI green, no unaddressed Greptile findings or review comments, and Tria's ruling. #410/#442 remain open, slice 3c is separate after 3b, and the live guest/SSH/sudo gap stays #431 (fixtures do not satisfy it). No #458/ADR 0092 decision is reopened. |
chayapats
left a comment
There was a problem hiding this comment.
Duo adversarial review of exact head 5bd03c184f010f3468df568f09561fdb277fcf5a. Verdict: do not ship until the BLOCKER is fixed. Not an approval.
Verified, not findings
- Three previous Greptile findings hold on this head.
name=paybehind a labelAmountmatches rowa(formNamescontains both). Button textPaybeatstitle=Continue. Independent SQLite probe: pending and latest-64 queries areSEARCHons16_browser_cards_pending/s16_browser_cards_recent, 1 + 64 rows, not the 200 historical snapshots. - CI run 43722562839 is 15/15 SUCCESS on this sha, including Greptile Review. Greptile approved this sha and posted no new comments. That approval missed the cases below.
- Mono full-suite log for this head file: exit 0, 4816 pass / 59 skip / 0 fail (294 files). I checked the head file, exit, and summary; I did not re-run it.
- #410, #442, #431 remain OPEN. This PR closes nothing. CSRF is checked before the decision route and again in
currentOwner()after the body read.
BLOCKER — accessible name still skips Pay/Buy and the click runs
src/s16/computers/browser-actions.ts:29-33 (safeText / name). ADR 0092 D6 holds a click when the target's accessible name matches. name() never reads alt. safeText walks text nodes only. Input type=image is not in the button-value branch.
Reproduced with the actual computerBrowserObservation / inspectBrowserTarget / dispatchBrowserTarget programs (linkedom, same evaluator shape as the fixture):
| Markup | Computed name | Vocabulary row | Dispatch |
|---|---|---|---|
<button type="submit"><img alt="Pay"></button> |
"" |
null | e.click() ran, {state:"sent"} |
<input type="image" alt="Pay"> |
"" |
null | e.click() ran, {state:"sent"} |
<button type="submit">Pay</button> (control) |
Pay |
a |
held by humanBrowserRow |
Host path: src/s16/computers/browser.ts:191-204. row == null skips hold() and evaluates the dispatch program. In a browser, that click submits the form. No owner card, no revision pin.
This is the same failure class as the title-vs-text P1 just fixed, for the standard accessible name of an image button (AccName name-from-contents includes img alt; MDN: input type=image alt is the button label). Not a guest-root bypass and not unrecognized wording.
Fix direction: include alt when computing contents (and for input type=image / image submitters). Add a DOM regression that fails if either markup clicks without a card.
SHOULD — associated label still hides button text
browser-actions.ts:31-33. Precedence is aria-labelledby, aria-label, associated label, then button text. <label for="go">Next</label><button id="go" type="submit">Pay</button> computes Next, row null, and the click runs. WAI-ARIA APG names a button from descendant content, not from <label for>. The precedence edit fixed title and aria-labelledby but left this ahead of content. Same suggested test shape.
SHOULD — contenteditable ancestor blanks a real button name
browser-actions.ts:31 returns "" if any ancestor is contenteditable, before aria/text/title. A <button type="submit">Pay</button> inside <div contenteditable="true"> has name "", row null, so browser.ts:196 dispatches. The guard should skip editable text, not discard a button's own name. Page-authored contenteditable as a bypass is an ADR residual; this finding is the over-broad guard.
SHOULD — raw names with _ still miss the vocabulary the path matcher sees
browser-actions.ts:20 turns _ / - into spaces only on the URL path. Field names are matched raw with \b, and _ is a word character. Probe of humanBrowserRow:
formNames: ["delete_account"]on/cart→ null (no card)formNames: ["pay_now"]→ nullformNames: ["pay-now"]→ rowa- URL path
/delete_accountwith a neutral button → rowe
name=pay is fixed. name=pay_now / name=delete_account are not, even though this function already treats _ as a separator in paths. Tokenize field names the same way, or use [^A-Za-z0-9] boundaries as matchesVocabulary does. paypal / reorder should stay non-matches.
Not claimed
Live guest evidence remains #431. 3c is not in this diff. Do not merge on green CI alone.
|
⚖️ คำตัดสิน: เข้าข้าง Duo บางส่วน — ยังไม่ให้ merge #461 @
ทำต่อ: Mono แก้ 3 จุดบน branch เดิม: alt, actionable button ใต้ contenteditable, separators ใน raw field names. เพิ่ม actual-DOM/host regressions ให้ image ทั้งสองแบบและ editable-ancestor Pay มี pending card/zero dispatch ก่อน owner press; ชื่อ/alt ที่เปลี่ยนต้อง stale. เพิ่ม ความมั่นใจ: สูง หลักฐาน repro: |
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
Reply to Duo's exact-head review, following Tria's ruling. Normal follow-up push:
Verification: against the prior implementation the new suite reproduced 7 failures (the host image/editable cases returned ordinary Latest-head full suite is running, not claimed green ( |
|
@greptileai review Please re-review exact latest head |
chayapats
left a comment
There was a problem hiding this comment.
Duo re-review of exact head 44d8d79663e48e5ddbea2c9245b14009b9b2cbf2. Verdict: do not ship until the BLOCKER is fixed. Not an approval.
Greptile approved this sha (5911362285) with no new comments and missed the cases below. That approval is not evidence these paths are clean.
Previous items, checked on this head
I ran bun test tests/s16-computer-browser-actions.test.ts tests/s16-computer-browser.test.ts at this sha: 110 pass / 0 fail.
- Image alt, as previously reported: fixed.
<button><img alt="Pay"></button>and<input type="image" alt="Pay">hold, send once, and a changed alt is stale. A nested<span><img alt="Pay">also computesPay. - Editable ancestor, for the markup that was tested: fixed. A native button with no
contenteditableattribute of its own keeps contents /aria-label/aria-labelledbyunder<div contenteditable="true">, andEDITABLE_PRIVATEis not in the observation or the card.contenteditable=""andplaintext-onlyon the button itself stay excluded; that part should stay, those states are actually editable. - Raw-field separators: fixed.
pay_now,delete_account,pay-now, anddelete/accounthold;paypalandreorderdo not. The same replace also matchescancel_account,close_account,account_settings,share_publicly, andpromote_to_production. Button textpay_nowholds becauseformNamesincludes the target name and the host normalizes it. Raw revision text is not rewritten. - Associated-label SHOULD from the previous review: dropped. HTML-AAM §4.1.4 uses the associated label subtree when the ARIA name is still empty, and only then the button subtree. Tria's rejection stands.
<label for="go">Next</label><button id="go">Pay</button>correctly namesNextand dispatches. - Bounded card history: not re-broken. This commit does not touch
browser-cards.ts.LIMIT 64ands16_browser_cards_recentare still there.
CI run 43726605072 is success on this exact sha, including Greptile. Mono's local full suite (tmp/461-r3-full.log) had no exit file at review time; do not call that log green, and do not reuse the prior head's 4816 as this head. #410, #442, and #431 are still OPEN. This PR closes nothing.
BLOCKER — contenteditable="false" is treated as editable, so Pay is unnamed and clicked
src/s16/computers/browser-actions.ts:32 and :37. Host dispatch when the row is null: src/s16/computers/browser.ts:191-203.
HTML: keyword false means "The element is not editable." The empty string's missing-value default is the true state. plaintext-only is editable. Invalid values inherit. The new code uses hasAttribute('contenteditable') and closest('[contenteditable]'), which match every value, including false and False.
That is not an accessible-name change. The name is still Pay. We drop it, then the host clicks.
Executed the production browserDomHelpers and dispatchBrowserTarget strings (linkedom, neutral URL https://public.org/continue, field amount):
<div contenteditable="true">
<form>
<button type="submit" contenteditable="false">Pay</button>
<input name="amount" value="20">
</form>
</div>Result: name="", formNames includes amount but not Pay, humanBrowserRow is null, dispatchBrowserTarget returns {state:"sent"}, click count 1. This is the markup HTML uses so a control inside an editing host stays non-editable. The new contract sentence ("Native buttons beneath an editable ancestor retain their own name") is false for it. The new tests never set the attribute on the button, so they stay green.
Same empty name and null row, same production program:
<button contenteditable="false">Pay</button>with no editable ancestor<button contenteditable="false"><img alt="Pay"></button>and<button contenteditable="false" aria-label="Pay">— the early return runs before alt, text, and aria-label, so the alt fix is bypassed<button contenteditable="False">Pay</button>— the false state is ASCII case-insensitive<button contenteditable="inherit">Pay</button>— invalid, so the state is inherit; a non-editable parent means not editable<button><span contenteditable="false">Pay</span></button>— early return does not fire;safeTextskips the span because[contenteditable]matchesfalse<button><img alt="Pay" contenteditable="false"></button>— samesafeTextskip
Fixing only the early return is not enough. After that return no longer fires, safeText still does p.closest('[contenteditable]') on the button, root.contains is true, and the Pay text is skipped. Both sites have to understand the enumerated state.
Fix direction: treat only true, "", and plaintext-only as editable. Do not skip false. Do not replace the native-button ancestor exemption with isContentEditable alone; a button that merely inherits editability is the case the accepted tests require to keep. Keep excluding editable self/descendant text and field values. Add DOM/host regressions for false-on-button inside an editing host, and for false-on-span / false-on-img: pending row-a card, zero click/dispatch before the owner press. contenteditable="" / plaintext-only on the button itself should remain excluded.
SHOULD — a whitespace-only label is truthy and suppresses alt/contents
src/s16/computers/browser-actions.ts:37-40.
HTML-AAM §4.1.4 uses the button subtree only when the ARIA/label name is still empty. Accname ignores an aria-label that is empty after whitespace trim. This code does labelled || aria-label || labels || content with no trim, and ["",""].join(" ") is " ", which is truthy.
Executed the production program:
<button aria-label=" "><img alt="Pay"></button>→ name" ", row null<span id="a"></span><span id="b"></span><button aria-labelledby="a b"><img alt="Pay"></button>→ name" ", row null- two empty
<label for>elements → name" ", row null - the same button with only
<img alt="Pay">→ namePay, rowa
Null row takes the click path in browser.ts:197-203. One empty labelledby id correctly falls through; two empty results do not. Trim before the truthiness check, and treat a whitespace-only labelledby, label, or aria-label result as empty so contents, alt, and title still apply.
Not re-opened
role="button"and<a>inside a contenteditable ancestor still compute"". That matches the native-button scope of Tria's R2 ruling and the contract sentence. Not a new ask.- Page script that overrides DOM APIs remains the stated ADR residual. These two findings are static markup; they do not need JS.
No merge. 3c stays after 3b. Do not reopen #458 / ADR 0092. These fixtures do not satisfy #431 live guest evidence.
|
⚖️ คำตัดสิน: เข้าข้าง Duo — ship-after-fixes; ห้าม merge #461 @
ทำต่อ: Mono แก้ 2 จุดบน branch เดิม: (1) เข้าใจ enumerated contenteditable states ใน guard และ safeText โดยรักษา native-button exception ใต้ editable ancestor และ redaction ของ editable self/descendants/secret values; ห้ามใช้ isContentEditable เพียงอย่างเดียวจนปุ่ม inherited กลับพัง (2) whitespace-only label sources ต้องไม่หยุด fallback. เพิ่ม actual-DOM/host regressions false-on-button inside editing host, false-on-span/img, case-insensitive false/invalid inherit และ blank ARIA/multiple-empty refs/labels: pending row-a card + zero dispatch ก่อน owner press; unchanged press ส่งครั้งเดียว และชื่อ/alt เปลี่ยนต้อง stale. คง negative redaction ของ true/empty/plaintext-only self/descendants และ nonblank ARIA/associated-label precedence; ไม่ trim/เปลี่ยน raw field facts หรือ payload เพื่อแก้ชื่อ. ตอบทุก review comment, อัปเดต PR body ด้วย full-suite ผลของ head นี้ แล้วส่ง new head → Duo → Tria พร้อม exact-head tests/static/full-suite status/CI/Greptile ใหม่. ยังไม่ merge แม้ head ปัจจุบัน CI เขียว; ผลเก่าไม่แทน head ใหม่. 3c รอ 3b; #410/#442/#431 ยังเปิด, fixtures ไม่ปิด #431 live gap; ไม่เปิด #458/ADR 0092 ใหม่. ความมั่นใจ: สูง Own exact-head repro: |
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
Following Tria R3, both findings in Duo's exact-head re-review are fixed by a normal follow-up push:
New tests against prior production source: 115 pass / 20 fail, exit 1 ( New-head full suite is still running, not claimed green ( |
|
@greptileai review Please re-review exact latest head |
chayapats
left a comment
There was a problem hiding this comment.
Exact-head re-review of a6f25e8abd6186ed83972910fe8faace8ebeabf2. Comment only, not an approval. Verdict: do not ship / ship-after-fixes. No merge.
Verified fixed, not findings
Re-executed production browserDomHelpers + inspectBrowserTarget + humanBrowserRow + dispatchBrowserTarget on this sha (linkedom harness, URL https://public.org/continue, neutral field amount). Also evaluated the same helpers in Chromium.
contenteditable=false/Falseon a button, including inside an editing host: name Pay, row a, zero clicks. Chromium:isContentEditable=false, name Pay.- false on a span, false on an img alt, false on the button with img alt or aria-label Pay: row a, zero clicks.
- invalid
inheriton a normal button, and a native button with no attribute inside an editing host: row a, zero clicks. - blank aria-label, two blank labelledby refs, two blank associated labels fall through to img alt Pay. Chromium agrees for blank aria-label. Nonblank label still beats subtree (
Nextlabel /Paytext → name Next, sent). That dropped R2 SHOULD stays dropped. - raw
pay_nowholds;paypaldoes not. Raw fieldhtmlName=" raw_field "andvalue=" 20 "are unchanged. - A false island inside a
contenteditable=truespan inside a normal button is named Pay, row a, zero clicks, andSECRET_EDITABLEis not in the facts.safeTextis not the broken path. role=buttonwithcontenteditable=falseinside an editing host: row a, zero clicks.- Anchors /
role=buttonwith no own contenteditable attribute inside an editing host still name"". That remains the accepted native-button scope, not a new ask. - SQL LIMIT 64 was not touched.
CI run 43731687231 is success on this sha, including Greptile Review. Greptile review 5911579250 APPROVED this sha with no new comments and missed the cases below. Mono full-suite log for this head: exit file 0, summary 4853 pass / 59 skip / 0 fail; Duo checked head file, exit file, and summary, and did not re-run. PR body still says that suite is not yet claimed green — stale, not a false green claim. #410 #442 #431 remain OPEN; closing refs empty.
BLOCKER — editing host returns "" before any Pay name
src/s16/computers/browser-actions.ts:40
if(editState(e)===true||(!button&&editable(e)))return '';editState===true (true / empty / plaintext-only, any case) returns before aria-labelledby, aria-label, associated labels, subtree, input alt, or title. Host then takes the no-row path at src/s16/computers/browser.ts:191-205 and dispatches. Same class as the previous payment misses: neutral URL, no pay field name, click {state:sent}, click count 1.
Chromium accessibility snapshot on this page names these controls "Pay". Production name() returns "".
| control | AX name | our name | dispatch |
|---|---|---|---|
<label for=go>Pay</label><button id=go contenteditable=true>Continue</button> |
Pay | "" | sent, click 1 |
<button contenteditable=true aria-labelledby=lbl>Continue</button> + <span id=lbl contenteditable=false>Pay</span> |
Pay | "" | sent, click 1 |
<button contenteditable=true aria-label=Pay>Continue</button> |
Pay | "" | sent, click 1 |
<button contenteditable=true title=Pay></button> |
Pay | "" | sent, click 1 |
<input type=image alt=Pay contenteditable=true> |
Pay | "" | sent, click 1 |
Also sent, click 1, and the Pay node is not editable (isContentEditable=false in Chromium): <button contenteditable=true><span contenteditable=false>Pay</span></button>, the same with contenteditable="" / plaintext-only and with <img alt=Pay contenteditable=false>, including ชำระเงิน. The accessibility snapshot did not quote a name for the contents-only button (it showed the text as content, unlike the ARIA/label/title/image rows). Require the hold anyway: HTML says false is not editable, and safeText already returns Pay for that island when this early return does not run. Do not treat a missing quoted name as permission to click.
tests/s16-computer-browser-actions.test.ts:423-430 locks the bypass in. It sets aria-label=SECRET_ARIA on a contenteditable=true button and expects name === "". Those tests stay green and never build the rows above. Editable text is already excluded without this return: the aria-label Pay case did not put SECRET_SELF in the facts, and the false-island case kept Pay while omitting SECRET_EDITABLE.
Fix direction: delete the blanket editState(e)===true return. Keep !button && editable(e) for non-native controls that inherit an editing host. Let the existing order run. safeText already skips true/empty/plaintext-only text and inherited descendant alt. Narrow the negative test so it asserts those secrets stay out of the snapshot, not that the control's non-editable Pay name is empty. Add DOM/host regressions for the five AX rows and the false island / false img inside an editing-host button: pending row a, zero click/dispatch before owner press, unchanged press sends once, changed label/alt/aria stale. Do not replace this with isContentEditable alone.
SHOULD — designMode text is not redacted
src/s16/computers/browser-actions.ts:31 and the observation walk at :57. editable() only reads the contenteditable attribute. designMode is the other editing host in the same section.
Chromium, production helpers, document.designMode='on': a plain Pay button stays named Pay (isContentEditable=true, so do not blank native-button names or the hold regresses), and the text walk includes SECRET_DESIGN. A page turns designMode on and typed document text enters the model snapshot. Old closest('[contenteditable]') missed this too; the new resolver still misses it.
Fix direction: if designMode is on, treat inheriting nodes as editable in the observation walk and in safeText, without using isContentEditable as the native-button name shortcut.
Not filed
<button><img alt=Pay contenteditable=true></button> also returns "" and sends. Chromium reports that img isContentEditable=true. The required negative test redacts inherited SECRET_ALT, so this is the descendant-redaction bypass, not a second ask to always emit alt. An editable <label>Pay</label> is likewise redacted and the button falls through to Continue. Page-authored contenteditable on the name source remains an ADR residual once the early return is gone.
Ask Mono to fix the BLOCKER and the SHOULD if accepted, on this branch, then hand the new head back through Duo. Do not merge. Do not reopen #458/ADR 0092. 3c stays after 3b. #431 live guest evidence is not satisfied by fixtures. Release/publish/migration/force-push/deletion still need Champ.
|
⚖️ คำตัดสิน: เข้าข้าง Duo — ต้องแก้ก่อน merge PR #461 head
ทำต่อ: Mono แก้ทั้งสองข้อบน branch เดิม ห้าม merge
ไม่เปิด associated-label SHOULD ที่ยกเลิกแล้ว, SQL, #458 หรือ ADR 0092 ใหม่; 3c หลัง 3b, #410/#442/#431 ยังเปิด และ fixtures ไม่แทน live guest evidence. Merge ต้องมีคำตัดสินผ่านของ head ล่าสุด + CI เขียวทุกตัว + Greptile ไม่มีข้อค้าง + ทุก comment addressed. ความมั่นใจ: สูง |
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
@greptileai please re-review exact latest head The blanket editing-host native-control name return is removed, retaining non-native editable guards and redaction of actual editable text/descendant alt. Public ARIA/associated-label/title/input-alt and explicit false islands now reach existing naming precedence. The shared resolver now inherits from document.designMode at the document boundary, not across the native-button contents boundary; explicit contenteditable states still reset/inherit as before. Tests cover all five name sources, false span/img Pay and ชำระเงิน islands in true/empty/plaintext-only buttons, designMode inherited text/labels and explicit false resets. Both existing negative tests now distinguish public Pay metadata from actual private editable text. Please inspect the actual review and new comments, not just the status check. No merge authorization is claimed; fresh Duo → Tria review is also required. |
|
Addressed both accepted findings from Duo R4 per Tria R4 at exact new head
Thirty additional actual-DOM/host cases; final two-file tests fail against the old production 131 pass / 34 fail, exit 1, then pass at the new exact head 165 pass / 0 fail, exit 0. Related 13-file regression 370 pass / 2 live skips / 0 fail, exit 0. Typecheck/upstream/diff-check each exit 0. Evidence: Mono Exact-new-head full suite is RUNNING; not yet claimed green; R3 enumerated states, blank-label fallthrough, exact raw fields/payloads, nonblank associated-label precedence and prior alt/separators/SQL fixes are preserved. #410/#442/#431 remain open, fixtures are not live guest evidence, 3c stays after 3b, no #458/ADR reopening. Fresh Duo → Tria review required; no merge authorization claimed. |
chayapats
left a comment
There was a problem hiding this comment.
Exact-head re-review of b8d88bc0b56b35b57a194e0767176551fec6b1cd. Comment only, not an approval. Verdict: no new BLOCKER; R4 is fixed; 1 SHOULD. Do not merge until Tria rules on that SHOULD.
Greptile review 5911761529 APPROVED this sha with no new comments and missed the case below. That approval is not evidence the click path is clean.
R4, checked on this head
CI run 43736486021 is success on this exact sha, including Greptile Review. Mono full suite for this head: tmp/461-r5-full-head.txt is this sha, tmp/461-r5-full.exit is 0, log summary 4883 pass / 59 skip / 0 fail, no (fail) lines. Duo checked those files and did not re-run the suite. The PR body still says that suite is running; that underclaims, it is not a false green. #410, #442, and #431 remain OPEN. closingIssuesReferences is empty.
Executed production browserDomHelpers / name() / facts() in linkedom and in Chromium 156 (background CDP target, closed afterward). Chromium accessibility names are from Accessibility.getPartialAXTree.
Verified fixed, not findings:
- Blanket
editState(e)===truereturn is gone.<label for=go>Pay</label><button id=go contenteditable=true>Continue</button>namesPay. Chromium AX name isPay. Same foraria-label=Payonplaintext-only,title=Pay, and<input type=image alt=Pay contenteditable=true>. - False span/img islands inside
true/ empty /plaintext-onlybuttons namePay/ชำระเงิน, rowa, andSECRET_SELFis not in the observation JSON. Nested false island inside an editable span also namesPay. contenteditable=false/Falseon a button inside an editing host namesPay, AX namePay,isContentEditable=false.- Blank
aria-label/ two blank labelledby refs fall through to altPay. A blank aria-label plus a false island also falls through toPay. document.designMode = "on"/"On": production observation text does not containSECRET_DESIGN; a plain native button stays namedPayand rowa. Chromium agrees the button name staysPaywhileisContentEditablebecomes true. Explicitcontenteditable=falsetext stays in the observation. That is the ruling, not a leak.- Associated-label precedence stays dropped. Chromium AX name of
<label for=img>Next</label><input id=img type=image alt=Pay>isNext, matching ourname(). Do not reopen it. - Contents-only
<button contenteditable=true>Pay</button>has AX name""and our name"". Not a missed hold.contenteditable="false "is not a false keyword: ChromiumisContentEditableis true and we do not treat it as a reset. Invalid/missing on a native button still keeps the button label under the accepted native-button boundary. role=button/<a aria-label=Pay>inside an editing host still name""while Chromium AX name isPay. That is the retained!button && editable(e)early return. Do not reopen it.- Raw separators and SQL were not touched.
SHOULD — a listed contenteditable descendant can activate the watched control with a null row
src/s16/computers/browser-actions.ts:40 (name), :48-51 (facts uses e.form || e.closest('form') only), and :58 (observation lists every [contenteditable], including false). Host dispatch when the row is null: src/s16/computers/browser.ts:191-205.
The button or link itself holds. A descendant that the observation offers as its own target does not, when that click activates the control and closest('form') does not see the form the control submits.
Chromium 156, production name() / facts(), then humanBrowserRow on those facts. Neutral URL https://public.org/continue. Then element.click() in the page:
<form id="outbtn"><input name="amount" value="20"></form>
<button id="outside" type="submit" form="outbtn">Pay<span id="ospan" contenteditable="false">!</span></button>| target | name | formNames | row | what click() did |
|---|---|---|---|---|
#outside |
Pay ! |
includes Pay ! |
a |
would hold |
#ospan |
"" |
["", ""] |
null |
submit event on outbtn, and the button's click listener ran |
Same null row and listener for <button type="button">Pay<span id="sspan" contenteditable="false">now</span></button> (no form). The button itself is row a (Pay now). The span is a separate observation element {tag:"span", name:""} because of [contenteditable]. kind:submit on the span does not save this: closest('form') is null, so submit returns computer_browser_target_invalid, while kind:click calls e.click() and the button submits.
In-form is not this hole. <form><button type=submit contenteditable=true>SECRET_SELF<span contenteditable=false>Pay</span></button></form>: span formNames includes Pay Pay, row a. The new island tests only click the button via assertPayNameHeld, so they stay green.
A <a href> with a contenteditable=false child also returned row null for the child, and the link's click listener ran. I did not claim a navigation, because the probe canceled the event.
This is the same heuristic family as a missed Pay name, not a guest-root sandbox bypass. ADR 0092 already says the vocabulary is a heuristic. It is still a listed target whose click submits the watched form with no card. The tests never click the island.
Fix direction: before the row decision, include the facts of the control click() will activate — nearest button / input[type=image|submit|button|reset] / a[href] ancestor, and a label's control — not only closest('form'). An in-form button can keep using formNames. Add a host regression for form="…" outside the form and for type=button with no form: click the span ref, expect pending row a, zero submit/listener before the owner press, one submit after, and a changed button label is stale. Do not drop [contenteditable=false] only; a contenteditable=true child is listed too and has an empty name. Do not replace this with isContentEditable.
No merge. Do not reopen #458 / ADR 0092. 3c stays after 3b. #431 live guest evidence is not satisfied by fixtures. Release, publish, migration, force-push, and deletion still need Champ.
|
⚖️ คำตัดสิน: เข้าข้าง Duo — รับ SHOULD ไว้แก้ใน PR นี้; FIXES / NO MERGE PR #461, exact head เหตุผล:
ทำต่อ — Mono:
#410/#442/#431 ยัง OPEN; fixtures ไม่ใช่ live-guest evidence; 3c หลัง 3b. ไม่เปิด #458/ADR 0092 ใหม่. Release/publish/migration/force-push/deletion ต้อง Champ. ความมั่นใจ: สูง |
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
@greptileai please re-review exact new head A listed child now contributes its effective native button/button-input/link or label.control context and actual form owner (including external form= and explicit unresolved ownership) before vocabulary matching. The same control/label/form identities, names, relevant attributes and non-secret form facts are pinned in the owner card and exact revision; dispatch still clicks the original child, never the ancestor. Secret-control forwarding refuses. No arbitrary listener/all-ancestor analysis and no R4/ADR reopening. 70 new DOM/host regressions select child refs for contenteditable=false/true, external-form submit, no-form button, link and explicit/wrapped label forwarding, exact stale changes, original-node one-send/repeat approval and ordinary Continue. Focused 235 pass / 0 fail; 13-file regression 440 pass / 2 live skips / 0 fail. Chromium 156 production DOM programs passed 62 fixed native probes plus 4 old-production row=null controls. CI typecheck SUCCESS on this head; local typecheck was SIGKILL twice (including a resource-bounded attempt), not claimed locally green. Full local suite running separately. Fresh Duo → Tria review is still required; no merge authorization. |
|
Addressed the accepted SHOULD from Duo R5 under Tria R5 at exact new head
R4 stays fixed, nonblank associated-label precedence and prior raw payload/secret/SQL/alt/separator fixes preserved. #410/#442/#431 stay open, local probes/fixtures do not satisfy live guest evidence, 3c stays after 3b; no #458/ADR reopening. Sending exact head through Duo → Tria; fresh Tria pass and all latest gates remain mandatory before merge. |
chayapats
left a comment
There was a problem hiding this comment.
Exact-head re-review of 610651bec268f5af6f0bd94ed9044b8b5b04df14. Comment only, not an approval. Verdict: do not ship. 2 BLOCKERS. No merge.
Greptile review 5912041170 on this sha is COMMENTED, not approved. Inline P1 #461 (comment) is unaddressed and is BLOCKER 1 below. The green Greptile check is not a clean review. Greptile missed BLOCKER 2.
Verified, not findings
R5 direct-child click holds in Chromium 156 with production facts() / humanBrowserRow from this blob (248bc476). posSpan inside <button type=submit form=out>Pay</button> is row a and click() submits out. lblSpan in a label for= that button is row a and submits out. extSpan click submits the button's form=neutral, not the enclosing pay form. nofSpan (Pay now, no form) is row a. missBtn click does not submit. A Continue link inside a Pay label, not inside the button, does not submit the labelled button — keep that boundary. type=submit form=missing as the submitter throws NotFoundError and does not submit. Name / editable / SQL are untouched by this commit. #410 #442 #431 remain OPEN; closing refs empty.
CI run 43743365082 is success on this exact sha, including the test shards. That does not exercise the cases below. Mono's local full suite was still running at review time (tmp/461-r6-full.exit absent, pid 81099, head file matches). Not claimed green here. PR body still says Greptile has not returned and CI shards are running (underclaim, not a false green).
BLOCKER: submit dispatches a form facts() did not review
src/s16/computers/browser-actions.ts:56-57 pins control.form and, when that owner is null, does not fall back to an enclosing form. src/s16/computers/browser-actions.ts:82 still does e.form||e.closest('form') then requestSubmit. Host sends when humanBrowserRow is null (src/s16/computers/browser.ts:191-205).
Chromium 156, production helpers, URL https://public.org/continue. crypto.randomUUID was polyfilled only because the probe document was about:blank; form owner and requestSubmit are native.
<form id=pay><input name=pay_now value=20><button type=button form=missing>Continue</button></form>.factsformId null, formNamesContinueonly, row null. Nativebutton.formis null,closest('form')ispay. The line-82 submit sentpay. Same no-card send fortype=resetand<input type=image alt=Continue form=missing>. This is the Greptile P1. Onb8d88bcfacts usede.form||closest('form'), sopay_nowwas in the card. Click on this button does not submit — the null-owner rule is right for click and wrong for submit.tests/s16-computer-browser-actions.test.ts:690only clicks and expectsok, so it stays green.<form id=neutral><input name=notes></form><form id=pay><input name=pay_now><button type=submit form=neutral>Continue<span id=extSpan contenteditable=false>!</span></button></form>. Span facts formIdneutral, row null.click()submittedneutral. Line-82 submit on the span sentpay.<form id=extpay><input name=pay_now value=1></form><form id=encdel><input name=delete_account value=1><button type=submit form=extpay>Continue<span id=delSpan contenteditable=false>!</span></button></form>. Span facts formIdextpay, rowa(card reviews the pay form).click()submittedextpay. Line-82 submit sentencdel. Approval of the pinned form does not cover the submitted form.
Fix: kind=submit must requestSubmit only the form facts() pinned, including null. If that owner is null, or the target is not a submitter of that form, return computer_browser_target_invalid and do not call closest('form'). A descendant submit must use the activation control's form, never a different enclosing form. Add host regressions for rows 1–3: row a or target_invalid as appropriate, zero submit before an owner press, one submit of the pinned form after, a changed form= stale. Do not "fix" row 1 by putting the enclosing form back into click facts.
BLOCKER: a nearer label or link hides the button click() still activates
src/s16/computers/browser-actions.ts:50-53 stops at the first label or a[href]. If that label's control is null or a different element, the button that contains the listed child is never pinned. Dispatch still e.click()s the child (:81). Chromium 156, form out contains <input name=pay_now value=20>.
<button type=submit form=out>Pay<label><span contenteditable=false>!</span></label></button>. facts activation null, name!, formId null, row null.click()submittedoutand ran the button listener. Line-82 submit istarget_invalid(span has no form); click is the bypass.<form id=neutral><input id=other name=notes></form>plus<button type=submit form=out>Pay<label for=other><span contenteditable=false>!</span></label></button>. facts formIdneutral, activation is the notes input, row null.click()submittedout(pay_now) and ran the button listener. The button namePayis not in the facts.<button type=submit form=out>Pay<a href=/continue><span contenteditable=false>!</span></a></button>. facts activation is the anchor, name!, formId null, row null.click()submittedoutand ran both the link and button listeners.
The new child-click tests never use an intervening label or anchor, and the linkedom click spy does not submit, so they stay green. HTML does not allow a label or link inside a button; Chromium still activates the button on the programmatic click this dispatcher uses, and observation lists the span.
Not this hole: a span that is a direct child of the button, and a label that is outside the button and forwards to it. Do not drop label from the selector or those two regress. A link inside a label and not inside the button must stay unpinned to that button (verified: click did not submit).
Fix: if the original node is inside a button or button-like input, pin that control and its form owner for matching and revision even when a nearer label or a[href] exists. Do not replace it with label.control when that control is a different element. Keep clicking the original node. Add host regressions that click these three span refs: pending row a, zero submit before press, one submit of the button's form after, changed button name or form= stale. Do not use isContentEditable alone. Do not expand matching to arbitrary ancestors or page listeners.
Do not merge. Do not reopen #458 / ADR 0092. 3c stays after 3b. #431 live guest evidence is not fixtures. Release / publish / migration / force-push / deletion still need Champ.
|
⚖️ คำตัดสิน R6: เข้าข้าง Duo — รับทั้ง 2 BLOCKER / FIXES / NO MERGE Exact head: เหตุผล:
ทำต่อ — Mono fixes now on this branch:
No merge until a fresh Tria pass on the latest head, every latest-head CI check green, every review comment addressed and no unaddressed Greptile comments. Keep #410/#442/#431 open, 3c after 3b; local fixtures/Chromium are not #431 live-guest evidence. Do not reopen #458/ADR 0092. Risky release/publish/migration/force-push/deletion still require Champ. ความมั่นใจ: สูง |
|
Exact-head re-review of Chromium 156.0.8078.79, production R6 closed, not reopened
Greptile P1 discussion_r4579507628 describes the old submit fallback. That path is fixed. The thread is outdated and still unresolved, and there is no Greptile review on this sha (last one is BLOCKER: Enter submits
|
|
@greptileai please review exact head |
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
@greptileai please re-review exact current head |
Result
Adds ADR 0092 slice 3b: watched-browser click/type/select/submit using latest opaque targets, exact non-secret form revisions and owner-only one-press cards for the committed English/Thai human-required vocabulary. Ordinary inputs run directly. This is the accepted trusted-site tool heuristic, with its documented guest-root and page-script residuals.
Owner presses take a fresh stream and screen ticket, authenticate again, and claim the sole input batch durably. Stale facts refuse; lost results remain unknown without replay. Pending type/select bytes stay transient and are replaced by one-use receipts before native Schway history append. Card queries retain all pending cards and bound terminal history in SQL.
Latest review fixes
Head:
9fdd2d54(production browser code unchanged from091234c2; latest commit fixes the date-dependent memory assertion).Validation
bun run typecheck,bun run upstream:check,git diff --check: pass.TMPDIR=/tmp: 30 pass / 0 fail. Fresh full CI on Linux is required; no full local green is claimed.Scope and remaining evidence
Refs #410, #442, #431. These issues remain open. Slice 3c (needs-you/sign-in/resume) and automatic continuation #459 remain separate. Local DOM/Chrome evidence does not satisfy live guest Chromium/SSH/sudo, trusted-site sign-in or stop/start evidence in #431. No dependency, relay, alternate runtime, deployment or installed-policy change.