You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(skills): review pinned packages and use them in guarded working computers - #465
Owners can import an inert GitHub commit or uploaded folder, inspect exact package/license bytes, review team/Bot availability and known recipients, and use supported instructions/resources/scripts in the actual working computer. Discovering an update retains the active pin until exact review. Revoke fences later tools, results and continuations; imported text never grants authority.
The Connections Skills/plugins tab uses the owning authenticated services for import, preview, dependency mapping, review/update/revoke and original-command recovery after a lost reply. Chat displays actual use pins. English/Thai, keyboard, mobile and authentication-loss paths use the real bundle.
Contracts and implementation
ADR 0095 and s16-skills-v1 record the selected public Schway ToolDefinition/placed-session backend contract, limits and alternatives. The pinned Rakazo comparison retains immutable provenance; no upstream runtime, code or dependency is imported. License/notice bytes remain in each package snapshot.
GitHub resolution persists the original command and resolved commit before fetching verified regular blobs. Folder labels make no remote-origin claim. Traversal, symlinks, forged identity, credential content and oversize packages refuse; install hooks/unsupported configuration are inventoried without execution. Dependencies must map to already-reviewed governed connections.
POLICY/TEAM/CHAT/DATA15 guard actual instruction/resource reads and transfers. Scripts execute through the same placed VM session, with bounded literal arguments, cancellation/deadline/claims and observed operation evidence. No protected-host execution, runtime installation or uncertain-effect replay exists.
Reviews freeze the displayed package recipient set. Bot-only copies require the assigned private computer. DATA15/MEM/TEAM ancestry survives tool observations, delegation, continuations, corrections, forget and artifact-derived inputs. Released guest copies retain their original private scope and recipient limits; review/revoke does not claim to erase guest-root copies or authorize unrelated private inputs.
An additive opt-in skills.sqlite journal retains exact reviews, receipts, pending imports and provenance. CHAT format 5, TEAM 3/4 and MEM 5/6 fence readers lacking the owning ports before writable open. New S15 installer configurations enable the explicit feature; S14 default, existing omitted configuration, installed/custom policies and host adoption retain their separate transitions.
Validation
Tested current head: ef013d5906b6e71c9cbe429d7d4d9bebca8a97d4.
bun run typecheck, bun run upstream:check (v2, 2 source files / 6 license entries) and git diff --check: pass. Frozen install passed; no dependency/lockfile change.
Current-head actual Chromium: JIT_S16_BROWSER_TESTS=1 bun test --timeout 60000 tests/s16-skills.browser.test.ts: 2 pass, 0 fail, 32 assertions / 14.78s. English 1440 px / Thai 390 px now also delay detail/recipient replies and re-select the same package, then upload two 64 KiB resources through the actual client.
Current-head bun test --timeout 30000 tests/ops-service-package.test.ts: 150 pass, 0 fail, 825 assertions / 30.05s; packages the actual source tree.
Earlier full local suite at 40297a5498ee9ed7dfe2d35b5e0c836f43dd09b2: 5,153 pass, 83 opt-in skips, 0 fail, 5,236 tests / 309 files / 888.12s. The subsequent fea25f4a head passed the complete GitHub x64/ARM64 matrix and 22 native Skills/Connections/computer-input regressions. Those historical receipts do not certify the current head; current-head GitHub x64/ARM64 CI and fresh Greptile review both pass: 15 successful checks, exact-head APPROVED at 5/5, and no unresolved review threads.
Review corrections
All four initial findings were reproduced and corrected. Revoke bypasses waiting imports and stale updates cannot restore it. A separate bounded package serializer supports the advertised 2 MiB snapshots without changing POLICY's 128 KiB limit or small-command identities. Equivalent work/source observations share immutable DATA15 snapshots; recent history selects bounded complete fragments before union, with owning DATA15-only inference contexts and fresh per-send privacy checks. Re-selecting the current package preserves pending detail/recipient requests.
Additional bounds conformance stages all 128 files with long portable UTF-8 paths through the same placed session in guarded commands of at most 60,000 bytes. Failed/unknown batches are never retried automatically. Tests verify immediate revocation during both a waiting import and update, complete 2 MiB folder/reopen/review, verified GitHub blobs above 128 KiB, nine messages with nine observations each with retention on/off (including the actual ninth interpreter context), selected legacy history ancestry, and native delayed-reply recovery.
Composed fixtures assert actual transferred bytes and script output, one placed session, unavailable/current dependency gates, unrelated private-data refusal before MCP I/O, private-computer custody, revoke during transfer/model wait, original-work continuation, copied-file ancestry and lost-effect evidence without replay. Native browser fixtures exercise the actual client and protected services; guest protocol/file-map fixtures do not certify physical guest-root isolation.
Real account/subscription/device, hostile-root network enforcement, physical restart and owner-host cutover remain separately evidenced by #408/#431/#432. No live credentials, production deployment or paid service is used by this PR. Parent #392 remains open.
[High impact] This head appears safe to merge based on the reviewed changes.
Summary
Adds owner-reviewed, pinned skill packages that Bots can read and use inside their working computer without granting new permissions.
Owners can review an exact skill package before making it available.
CHAT can use reviewed skill instructions and scripts in guarded work.
Protected source ancestry follows skill observations into later work.
No new actionable issues were found at this head.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Owner imports exact files] --> B[Inert pinned package]
B --> C[Owner reviews scope and recipients]
C --> D[Guarded instruction and resource reads]
C --> E[Guarded staging and scripts]
E --> F[Existing working computer session]
D --> G[Retained source history]
F --> G
G --> H[Later privacy checks]
I[Owner revokes package] --> J[Block further activation and loaded work]
@greptileai please re-review exact head ef013d5906b6e71c9cbe429d7d4d9bebca8a97d4. All four initial inline findings have concrete fixes, evidence-backed replies and resolved threads. New regressions cover revocation during waiting imports/updates, complete 2 MiB folder custody and large verified GitHub/client imports, nine messages with nine observations each with retention on/off and actual retained interpreter context, bounded legacy history with private/revocation fences, and repeated package selection during delayed native detail/recipient replies. The 128-file UTF-8-path case also runs through bounded staging commands in the same placed session without retry. Affected regressions: 152 pass; actual English/Thai Chromium: 2 pass; package checks: 150 pass; typecheck/provenance/diff checks pass. Current-head CI is running; the PR body distinguishes these results from earlier full-suite receipts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #420
Refs #392
Owners can import an inert GitHub commit or uploaded folder, inspect exact package/license bytes, review team/Bot availability and known recipients, and use supported instructions/resources/scripts in the actual working computer. Discovering an update retains the active pin until exact review. Revoke fences later tools, results and continuations; imported text never grants authority.
The Connections Skills/plugins tab uses the owning authenticated services for import, preview, dependency mapping, review/update/revoke and original-command recovery after a lost reply. Chat displays actual use pins. English/Thai, keyboard, mobile and authentication-loss paths use the real bundle.
Contracts and implementation
skills.sqlitejournal retains exact reviews, receipts, pending imports and provenance. CHAT format 5, TEAM 3/4 and MEM 5/6 fence readers lacking the owning ports before writable open. New S15 installer configurations enable the explicit feature; S14 default, existing omitted configuration, installed/custom policies and host adoption retain their separate transitions.Validation
Tested current head:
ef013d5906b6e71c9cbe429d7d4d9bebca8a97d4.bun run typecheck,bun run upstream:check(v2, 2 source files / 6 license entries) andgit diff --check: pass. Frozen install passed; no dependency/lockfile change.bun test --timeout 60000 tests/s16-skills-service.test.ts tests/s16-skills-composition.test.ts tests/s16-skills-disclosure.test.ts tests/s16-skills-continuation.test.ts tests/s16-skills-package.test.ts tests/s16-skills-github.test.ts tests/s16-skills-continuity.test.ts tests/s15-memory.test.ts tests/s15-team.test.ts tests/s16-file-memory.test.ts tests/s16-computer-continuation.test.ts: 152 pass, 0 fail, 1,111 assertions / 40.54s.JIT_S16_BROWSER_TESTS=1 bun test --timeout 60000 tests/s16-skills.browser.test.ts: 2 pass, 0 fail, 32 assertions / 14.78s. English 1440 px / Thai 390 px now also delay detail/recipient replies and re-select the same package, then upload two 64 KiB resources through the actual client.bun test --timeout 30000 tests/ops-service-package.test.ts: 150 pass, 0 fail, 825 assertions / 30.05s; packages the actual source tree.40297a5498ee9ed7dfe2d35b5e0c836f43dd09b2: 5,153 pass, 83 opt-in skips, 0 fail, 5,236 tests / 309 files / 888.12s. The subsequentfea25f4ahead passed the complete GitHub x64/ARM64 matrix and 22 native Skills/Connections/computer-input regressions. Those historical receipts do not certify the current head; current-head GitHub x64/ARM64 CI and fresh Greptile review both pass: 15 successful checks, exact-head APPROVED at 5/5, and no unresolved review threads.Review corrections
All four initial findings were reproduced and corrected. Revoke bypasses waiting imports and stale updates cannot restore it. A separate bounded package serializer supports the advertised 2 MiB snapshots without changing POLICY's 128 KiB limit or small-command identities. Equivalent work/source observations share immutable DATA15 snapshots; recent history selects bounded complete fragments before union, with owning DATA15-only inference contexts and fresh per-send privacy checks. Re-selecting the current package preserves pending detail/recipient requests.
Additional bounds conformance stages all 128 files with long portable UTF-8 paths through the same placed session in guarded commands of at most 60,000 bytes. Failed/unknown batches are never retried automatically. Tests verify immediate revocation during both a waiting import and update, complete 2 MiB folder/reopen/review, verified GitHub blobs above 128 KiB, nine messages with nine observations each with retention on/off (including the actual ninth interpreter context), selected legacy history ancestry, and native delayed-reply recovery.
Composed fixtures assert actual transferred bytes and script output, one placed session, unavailable/current dependency gates, unrelated private-data refusal before MCP I/O, private-computer custody, revoke during transfer/model wait, original-work continuation, copied-file ancestry and lost-effect evidence without replay. Native browser fixtures exercise the actual client and protected services; guest protocol/file-map fixtures do not certify physical guest-root isolation.
Real account/subscription/device, hostile-root network enforcement, physical restart and owner-host cutover remain separately evidenced by #408/#431/#432. No live credentials, production deployment or paid service is used by this PR. Parent #392 remains open.