-
Notifications
You must be signed in to change notification settings - Fork 45
Ability to block extensions installation via CLI and VSIX #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Ability to block extensions installation via CLI and VSIX #617
Conversation
f04ba89 to
fefec71
Compare
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-617-amd64 |
8d51c2d to
437f2a9
Compare
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-617-amd64 |
…on side Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
…IONS env var Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
437f2a9 to
e794c63
Compare
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-617-amd64 |
Depends on: #605
What does this PR do?
default extensionsfunctionality from the che-extension to the VS Code sidevscode-editor-configurationsConfigMap =>policy.jsonsection =>BlockCliExtensionsInstallationpropertyworkbench.extensions.command.installFromVSIXAPI command:vscode-editor-configurationsConfigMap =>policy.jsonsection =>BlockInstallFromVSIXCommandExtensionsInstallationpropertyvscode-editor-configurationsConfigMap =>policy.jsonsection =>BlockDefaultExtensionsInstallationpropertyWhat issues does this PR fix?
How to test this PR?
Prerequisites
Add
default-extensionsConfigMap to your namespace:default-extensions ConfigMap
Add
vscode-editor-configurationsConfigMap to your namespace:vscode-editor-configurations ConfigMap
Use Cases:
1. Default extensions should be installed when "Install from VSIX" is disabled (fix for `CRW-9626`)
/checode/checode-linux-libc/ubi9/bin/remote-cli/code-oss --install-extension /projects/web-nodejs-sample/redhat.java-1.43.1.vsix/checode/checode-linux-libc/ubi9/bin/remote-cli/code-oss --install-extension /projects/web-nodejs-sample/vscode-test-extension-0.0.1.vsixF1=>Test 'installFromVSIX'Expected behavior:
Extensionspanel =>...=>Install from VSIXaction is absentExtensionspanel =>Atlassian,SnowflakeandYAMLextensions are installed asdefaultextensionsLanguage Support for Javaextension is installed using CLITools for MicroProfileextension is installed using'workbench.extensions.command.installFromVSIXAPI command2. Default extensions should be installed, but installation using CLI should be blocked
vscode-editor-configurationsConfigMapnewworkspace: click here/checode/checode-linux-libc/ubi9/bin/remote-cli/code-oss --install-extension /projects/web-nodejs-sample/redhat.java-1.43.1.vsixExpected behavior:
Extensionspanel =>...=>Install from VSIXaction is absentExtensionspanel =>Atlassian,SnowflakeandYAMLextensions are installed asdefaultextensionsLanguage Support for Javaextension installation was failed using CLI3. Default extensions should be installed, but installation using workbench.extensions.command.installFromVSIX API command should be blocked
vscode-editor-configurationsConfigMapnewworkspace: click here/checode/checode-linux-libc/ubi9/bin/remote-cli/code-oss --install-extension /projects/web-nodejs-sample/vscode-test-extension-0.0.1.vsixF1=>Test 'installFromVSIX'Expected behavior:
Extensionspanel =>...=>Install from VSIXaction is absentExtensionspanel =>Atlassian,SnowflakeandYAMLextensions are installed asdefaultextensionsTools for MicroProfileextension installation was failed using'workbench.extensions.command.installFromVSIXAPI command4. Default extensions installation should be blocked
vscode-editor-configurationsConfigMapnewworkspace: click hereExpected behavior:
Extensionspanel =>...=>Install from VSIXaction is absentExtensionspanel =>Atlassian,SnowflakeandYAMLextensions are NOT installed asdefaultextensionsDoes this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder