fix(netfilter): handle existing nftables tables gracefully during res… - #3136
Draft
alter-yash wants to merge 2 commits into
Draft
fix(netfilter): handle existing nftables tables gracefully during res…#3136alter-yash wants to merge 2 commits into
alter-yash wants to merge 2 commits into
Conversation
…tore Signed-off-by: Yash Maurya <iyashmauryagdsc@gmail.com>
alter-yash
force-pushed
the
fix-nftables-restore
branch
from
September 4, 2026 06:01
c5faccd to
8aebcca
Compare
alter-yash
marked this pull request as ready for review
September 4, 2026 06:04
alter-yash
marked this pull request as draft
September 4, 2026 10:07
Signed-off-by: Yash Maurya <iyashmauryagdsc@gmail.com>
alter-yash
force-pushed
the
fix-nftables-restore
branch
from
September 4, 2026 10:13
8898922 to
c345f59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
When restoring a container into an already existing, persistent network namespace, CRIU fails during the netfilter restoration phase with an
nftables"File exists" error because it blindly attempts to recreate tables that are already present in the namespace.How it does it:
This patch modifies the netfilter restore logic to make
nftablestable creation idempotent. If a table already exists during the restoration phase, the error is handled gracefully and the process continues, rather than throwing a fatal error and aborting the restore.Testing:
Validated on OpenSUSE Tumbleweed using a
runcreproducer. Checkpointed a running container and successfully restored it into an existing, persistent network namespace (ip netns add repro-netns) without triggering theFile existstable conflict inrestore.log.Fixes: #3135
Signed-off-by: Yash Ashok Maurya iyashmauryagdsc@example.com