Run tests against more Rails versions - #22
Open
skatkov wants to merge 15 commits into
Open
Conversation
skatkov
marked this pull request as draft
December 29, 2025 19:42
skatkov
commented
Dec 29, 2025
skatkov
force-pushed
the
run-against-more-versions
branch
from
December 29, 2025 20:43
9eca6de to
486a939
Compare
skatkov
force-pushed
the
run-against-more-versions
branch
from
December 29, 2025 21:15
66487db to
c01e986
Compare
skatkov
changed the title
skatkov
force-pushed
the
run-against-more-versions
branch
from
December 29, 2025 21:21
cb9e733 to
86f31d2
Compare
skatkov
marked this pull request as ready for review
December 29, 2025 21:26
skatkov
force-pushed
the
run-against-more-versions
branch
from
December 29, 2025 21:27
6d76e58 to
d88387f
Compare
Contributor
Author
|
@julik @jujustayfly can I ask for a review for this small PR? |
Contributor
|
@skatkov I am not a maintainer on any Cheddar repos anymore 🤷 |
Contributor
Author
|
@julik it seems, that I can still merge my changes. But would still love to hear feedback before I do, if you are up for it of course. edit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed munster related deprecation warning in Rails 8.0.
Munster relies on ActiveSupport::Configurable and will probably stop working in rails 8.2.
Before we proceed with a fix - it would be nice to run testsuit with different rails (and maybe ruby) versions. The goal of this PR is to run test suite under different rails versions, streach goal is to have different ruby versions as well. (ruby 4.0!! yaaay!)