simplify API, and drop non-finegrained representations #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses @bigmistqke's refcounting idea for maintaining the event listeners even after the first projection for a store cleans up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i've added a bunch of new tests, and rewritten everything else. some of this owes a lot to @bigmistqke's PR at #2.
makeDocumentProjection-> take a handle, return a live fine-grained doc viewcreateDocumentProjection-> take an accessor of a handle, return an accessor of a live fine-grained doc view (reactive input)useHandle-> take an automerge URL, return a Resource for a ready DocHandleuseDocument-> take an automerge URL, return a[doc(), handle()]and then there's the repo context.