core: review follow-ups — preflight test coverage + parameterized feature stripping - #31
Open
mat10d wants to merge 2 commits into
Open
core: review follow-ups — preflight test coverage + parameterized feature stripping#31mat10d wants to merge 2 commits into
mat10d wants to merge 2 commits into
Conversation
Covers the resolution outcomes the run manifest depends on: the full resolved_params record (sent/dropped/thinking), resolve-once stability against post-resolution mutation, one Models-API lookup per model via the capability cache, and the enabled-thinking budget staying within max_tokens.
build_evidence_bundles(feature_columns=...) lets feature column names vary and the per-gene keys come straight from the annotated chunk, but strip_feature_fields only removed the three standard names -- custom feature columns survived the strip and leaked into prompts. The field set is now a parameter (default: the standard builder output), and the docstring names the contract for custom-column bundles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The review follow-ups from the #25–#27 merge round, delivered as their own reviewable unit — one commit per comment:
6cf3349— preflight unit-test coverage (#25 review): the fullresolved_paramsrecord (sent/dropped/thinking), resolve-once stability under post-resolution mutation, one Models-API lookup per model (capability cache), and the enabled-thinking budget bounds. Tests only, no behavior change.9017dcf— parameterized feature stripping (#26 comment):strip_feature_fields(bundle, fields=...)per your design — field names flow frombuild_evidence_bundles(feature_columns=...), so the strip takes the field set as a parameter (default = the standard builder output) instead of matching three fixed names. Includes a test showing the custom-column boundary both ways.The third comment from the round — the batch-path source gate on #27 — was fixed pre-merge in
8095135(threaded per-request likeinclude_features, regression-tested).Validation
Full suite at tip: 399 passed. Reviewer's guide: read
9017dcf's prompt_factory diff first (11 lines); everything else is tests.