Add rexml as an explicit runtime dependency - #169
Open
Fs00 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Francesco Saltori <francescosaltori@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
Author
|
CI failures on older Rubies appear to be unrelated to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
rexml is a bundled gem since Ruby 3, which means that it needs to be added to the gemspec/Gemfile in order to be
required.The lack of the explicit dependency caused the error
LoadError: cannot load such file -- rexml/documentin our staging/prod environments, which has been tricky to debug because in dev environments we have test dependencies that depend on rexml and therefore mitigate its absence in theartifactorygemspec.Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.