Add support for OSC 9;4 - #64
Merged
Merged
Conversation
This allows the download progress to be communicated to terminal emulators. Eg. Konsole and Windows Terminal can show the progress in the tab bar or taskbar icon. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Owner
Author
|
I'm going to switch to using anstyle-progress once rust-cli/anstyle#348 is merged. After testing with various terminal emulators, it looks like the ones that don't support OSC 9;4 just print garbage to the screen. I don't want to maintain my own compatibility list. |
epage
reviewed
Jul 30, 2026
| }; | ||
|
|
||
| use indicatif::{BinaryBytes, MultiProgress, ProgressState, style::ProgressTracker}; | ||
| use indicatif::{BinaryBytes, MultiProgress, ProgressBar, ProgressState, style::ProgressTracker}; |
There was a problem hiding this comment.
I've also started work on integrating this into indicatif. I've at least go the PR against console up. I just need to do the indicatif side.
Owner
Author
There was a problem hiding this comment.
Thanks, looking forward to that!
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Jul 31, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the download progress to be communicated to terminal emulators. Eg. Konsole and Windows Terminal can show the progress in the tab bar or taskbar icon.