feat(di): Added the ability to add dependencies when creating a container #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesedo
reviewed
Nov 20, 2025
Owner
chesedo
left a comment
chesedo
left a comment
There was a problem hiding this comment.
Thanks for this!!
I'm going to have a lot of questions to ensure this can evolve in the future. But this already seems close to workable
despatma-dependency-container/tests/expand/constructor_argument.rs
Outdated
Show resolved
Hide resolved
despatma-dependency-container/tests/expand/constructor_argument.expanded.rs
Show resolved
Hide resolved
chesedo
reviewed
Nov 26, 2025
Owner
chesedo
left a comment
chesedo
left a comment
There was a problem hiding this comment.
I'm happy with this approach not blocking (possible) future expansions. Just some notes on the code and an updated doc is missing.
despatma-dependency-container/src/processing/visitor/extract_embedded_dependency.rs
Outdated
Show resolved
Hide resolved
despatma-dependency-container/src/processing/visitor/impl_trait_fields.rs
Show resolved
Hide resolved
despatma-dependency-container/tests/expand/async_constructor_argument.expanded.rs
Show resolved
Hide resolved
Contributor
Author
|
I've fixed all the points we discussed. Can I squash commits? |
Owner
I'll just squash on merge |
Owner
|
Thanks for this @libmonsoon-dev !! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue