fix: clear sessionStorage in fetchAll to ensure data freshness#316
Open
ArtemZhyto wants to merge 1 commit intochicagopcdc:masterfrom
Open
fix: clear sessionStorage in fetchAll to ensure data freshness#316ArtemZhyto wants to merge 1 commit intochicagopcdc:masterfrom
ArtemZhyto wants to merge 1 commit intochicagopcdc:masterfrom
Conversation
|
Hi @ArtemZhyto I just wanted to clarify something regarding this issue. I had previously reported and worked on this issue, and I also referenced it in my proposal. I believe there might have been a misunderstanding since the issue reference didn’t get properly linked in my earlier PR. Sorry for any confusion caused. You can check my earlier mention on the issue thread for reference. Wishing you the best of luck with your contributions, and I truly hope you achieve great milestones in GSoC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #295 by ensuring that
sessionStorageis cleared whenever a full data re-fetch is triggered.Changes
sessionStorage.removeItem()calls forstudies,eligibility-criteria, andmatch-conditionsinside thefetchAllfunction.Why this is necessary
Currently, the API hooks check
sessionStorageand return cached data indefinitely if present. By clearing these keys at the start offetchAll, we force the application to perform actual network requests and update the UI with the latest information from the backend.Note on Implementation
The key
gearbox:eligiblity-criteriaintentionally includes the existing typo to ensure it correctly targets the current storage key used in the codebase.Fixes #295