Skip to content

Comments

feat(ci): add lint and type check GitHub Action#319

Open
rahul810050 wants to merge 1 commit intochicagopcdc:masterfrom
rahul810050:feat/ci-lint-typecheck
Open

feat(ci): add lint and type check GitHub Action#319
rahul810050 wants to merge 1 commit intochicagopcdc:masterfrom
rahul810050:feat/ci-lint-typecheck

Conversation

@rahul810050
Copy link

Description

This PR adds a GitHub Actions workflow that automatically runs linting and TypeScript checks on every pull request to ensure code quality and prevent type errors.

Changes Made

  • Created .github/workflows/ci.yml with lint and type-check workflow
  • Workflow runs ESLint, TypeScript compiler, and Prettier checks
  • Configured to run on PRs to master and dev branches
  • Added npm dependency caching for faster execution
  • Set up Node.js 18 (matching project requirements)

Why This is Needed

Without automated checks, code quality issues and type errors can slip into the codebase. This workflow ensures:

  • Consistent code style across the project
  • No TypeScript errors are introduced
  • All code meets the project's quality standards

Testing Done

  • Verified workflow runs on PR creation
  • Tested with intentional lint errors to ensure failure
  • Tested with intentional type errors to ensure failure
  • Confirmed successful run with clean code

Related Issue

Closes #(issue-number)

Screenshots

[Add screenshot of successful workflow run]

Checklist

  • My code follows the project's style guidelines
  • I have tested the workflow locally using act
  • Documentation has been updated if needed

Fixed Issue: #318

Signed-off-by: rahul810050 <rahul810050@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant