Fix break AES-128-CBC on Ruby 2.5.3. Change hard code 32 key len by cipher key len returned by OpenSSL. #18
Open
ntloi95 wants to merge 1 commit intochicks:masterfrom
Open
Fix break AES-128-CBC on Ruby 2.5.3. Change hard code 32 key len by cipher key len returned by OpenSSL. #18ntloi95 wants to merge 1 commit intochicks:masterfrom
ntloi95 wants to merge 1 commit intochicks:masterfrom
Conversation
…break on Ruby 2.5.3
|
@chicks any thoughts on this PR? |
Author
|
This project is deserted. :'( @dennissivia |
|
@ntloi95 I guess you are right. Seems as if it will take some time until the PR will be merged if it will ever happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding to the issue #17
Error in Ruby 2.5.3, set cipher.key: Exception “key must be 16 bytes"
OpenSSL::Cipher.new('AES-128-CBC') only accept key with length is 16 bytes.
While in the code, it return 32-byte-key with totally 16 trailing zero bytes:
@key.unpack('a2'*32).map{|x| x.hex}.pack('c'*32) => "o\xA8\xBB\a#'\xF8\xD0\xE4\v\x85\xFA\xD9\x05\x10\xF9\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00"