Fix install.sh version regex to allow v prefix#10
Merged
Conversation
The artifact bundle directory is named xpbc-v0.2.0-macos (with v prefix from the git tag), but the version validation regex only accepted bare semver without the v prefix. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shの VERSION バリデーション正規表現を^[0-9]+\.[0-9]+\.[0-9]+$→^v?[0-9]+\.[0-9]+\.[0-9]+$に修正xpbc-v0.2.0-macos(git tag のvプレフィックス付き) であるため、vを許容する必要があるTest plan
curl -fsSL .../install.sh | bashで v0.2.0 がインストールできること🤖 Generated with Claude Code