-
-
Notifications
You must be signed in to change notification settings - Fork 25
Fix for deprecations from Symfony Validator 7.4 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
1422292
f5858c5
14e57f1
28073a4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,14 +15,14 @@ public function __construct( | |
| * the URL path to be accessible by UserAgent:Google-Valuables. | ||
| */ | ||
| #[NotBlank] | ||
| #[Url] | ||
| #[Url(requireTld: true)] | ||
| public string $url, | ||
| /** | ||
|
Comment on lines
17
to
20
|
||
| * Optional. | ||
| * URL for the merchant endpoint that would be called to request updates. The URL should be hosted on HTTPS | ||
| * and robots.txt should allow the URL path to be accessible by UserAgent:Google-Valuables. | ||
| */ | ||
| #[Url] | ||
| #[Url(requireTld: true)] | ||
| public ?string $updateRequestUrl = null, | ||
|
Comment on lines
24
to
26
|
||
| ) { | ||
| parent::__construct(); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requireTld: trueis a behavior change for URL validation (it rejectslocalhost/intranet hosts). If this is only meant to address the Symfony 7.4 deprecation, consider settingrequireTldto the value that matches previous releases (or document the stricter validation and add a test for it).