Update conda environment for osx-arm64 architecture#20
Merged
Conversation
d33bs
marked this pull request as ready for review
July 31, 2025 17:00
the-mayer
reviewed
Aug 1, 2025
| - defaults | ||
| dependencies: | ||
| - r-base=4.3.* | ||
| - r-base=4.4.* |
Contributor
There was a problem hiding this comment.
Good change as this version is no longer vulnerable to https://nvd.nist.gov/vuln/detail/CVE-2024-27322
the-mayer
approved these changes
Aug 1, 2025
Contributor
There was a problem hiding this comment.
Seem like good changes, especially if r-archr is not needed. Down the line, it may be worthwhile to use reticulate to manage Python environments, though not needed at this stage.
Approving!
Collaborator
Author
|
Thanks @the-mayer, great thoughts! @msubirana - how would you like us to proceed? Would you like to give this a review and / or merge if appropriate? Thank you in advance. |
Collaborator
|
Looks great, nice job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #19 and attempting to initialize the environment I found I was unable to install on MacOS with
arm64architecture. I found these changes were required for compatibility. Special thanks goes to @msubirana who confirmed thatr-archris not required in this project (their conda builds excludeosx-arm64architecture and would otherwise make installs a challenge).