Skip to content

Scryfall downloader#298

Open
DorkSoul wants to merge 10 commits into
chilli-axe:masterfrom
DorkSoul:scryfall-downloader
Open

Scryfall downloader#298
DorkSoul wants to merge 10 commits into
chilli-axe:masterfrom
DorkSoul:scryfall-downloader

Conversation

@DorkSoul

@DorkSoul DorkSoul commented Jun 14, 2025

Copy link
Copy Markdown

Description

Had a program I made to download cards from scryfall for myself and decided to see about adding it to mpc autofill for everyone to use.

No idea if this is something that would be wanted here but was an interesting project and something I will use myself with your fantastic program

This is an addition to allow the user to use a decklist exported from sites like moxfield and saved in a .txt file.

If this is something that is useful to you ill work on doing some actually tests for coverage rather then jsut manual testing

Didn't see a readme that I would be updating just a link to the github wiki which I cant seem to add to in this. Let me know where to add the readme for the two supported .txt format and any other info.

Checklist

  • I have installed pre-commit and installed the hooks with pre-commit install before creating any commits.
  • I have updated any related tests for code I modified or added new tests where appropriate.
  • I have manually tested my changes as follows:
    • tested on multiple normal decklists using both XML and TXT.
    • tested on a decklist with one of each type of card layout from the scryfall api.
    • tested on a decklist with one of each type of card layout from the MPC autofill.
    • tested on a decklist with multiple meld cards. some with both some with one.
  • I have updated any relevant documentation or created new documentation where appropriate.

@ndepaola

Copy link
Copy Markdown
Collaborator

Thank you for submitting this PR! I'll aim to review this over the next couple of weeks.

@DorkSoul

Copy link
Copy Markdown
Author

added a load of tests and fixed a border issue on the back of scryfall meld cards. Should have most of the coverage now. Still a few places I could probably add a test for edge cases or failures but for now that's most of them.

@ndepaola

Copy link
Copy Markdown
Collaborator

Hey mate, sorry for the quietness on this. Life has been pretty hectic for me lately so I haven't had much time to devote to open source dev. I do still plan on reviewing this code so we can get it in but can't really give you a timeframe on when that will be 😭

@DorkSoul

Copy link
Copy Markdown
Author

No rush was just something I threw together for myself since the Final Fantasy cards were missing a load of images at the time since it was before release and figured others may use it.

POST_LAUNCH_HTML_FILENAME = "post-launch.html"

# Card physical dimensions for border calculation
CARD_WIDTH_INCHES = 2.5

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CARD_WIDTH_INCHES = 2.5
CARD_WIDTH_INCHES = 2.48
CARD_HEIGHT_INCHES = 3.46
BORDER_INCHES = 0.12

these are the actual values that MPC uses (or at least a bit closer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants