Repository navigation
fix: guard X Layer publisher against stale pending nonce - #36
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incident and cause
The first scheduler-owned canary after PR #35 returned
PublicationErrorfor NVDAx, SPYx, and AAPLx. No new Registry transactions were mined. A read-only check for the production signer showed chain 1952 reportinglatest nonce=3320butpending nonce=3316; both documented X Layer Testnet RPC endpoints returned the same four-nonce regression. The existing latest nonce includes the four confirmed SPY/AAPL vault and policy transactions. The publisher previously trusted the stalependingvalue when building its transaction.Fix
The publisher now reads both nonce tags and uses
max(latest, pending). Thus an RPC pending value cannot send a transaction with an already-consumed nonce, and a genuinely higher pending nonce is still respected. The existing shared publisher transaction lock remains unchanged; there is no parallel submission path.Scope
apps/api/valtide_api/publisher.pyand its publisher tests change.AUTO_PUBLISH_ENABLED=false,PUBLISH_ENABLED=false. No canary retry or manual publish was sent while this correction is pending.Validation
After exact-head CI is green, this small fix must be merged and deployed before re-enabling scheduler publication.