fix: replace unsafe int-to-pointer cast in SiCalledDeleteIpTable#4
Draft
Copilot wants to merge 2 commits into
Draft
fix: replace unsafe int-to-pointer cast in SiCalledDeleteIpTable#4Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…ter in SiCalledDeleteIpTable Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix build warning in Server.c
fix: replace unsafe int-to-pointer cast in SiCalledDeleteIpTable
Feb 22, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a compiler warning caused by an unsafe integer-to-pointer cast in SiCalledDeleteIpTable that occurs on 64-bit platforms where pointers are wider than 32-bit integers.
Changes:
- Updated
SiCalledDeleteIpTableto use the properIsInListKeyandListKeyToPointerAPI functions instead of direct casting - Aligns the implementation with the pattern already used in
StDeleteIpTablefor identical operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Cedar/Server.c | Replaced unsafe (void *)key and (IP_TABLE_ENTRY *)key casts with IsInListKey and ListKeyToPointer API calls |
| _codeql_detected_source_root | CodeQL configuration file addition (unrelated to the fix) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SiCalledDeleteIpTablewas casting aUINTkey directly toIP_TABLE_ENTRY *, producing a-Wint-to-pointer-castwarning on 64-bit targets where pointers are wider than 32 bits.Changes
src/Cedar/Server.c: ReplaceIsInList(h->IpTable, (void *)key)+(IP_TABLE_ENTRY *)keywith the properIsInListKey/ListKeyToPointerAPI — the same pattern already used inStDeleteIpTable(Admin.c) for the identical operation.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.