chore: remove dead code and stale artifacts#184
Merged
Conversation
Codebase cleanup audit — remove unused files/config with no behavior change: - Delete 6 unused shadcn/ui primitives (alert, empty, field, toggle-group, toggle, label) — a self-contained cluster with zero inbound references (toggle was used only by toggle-group; label only by field). - Remove 3 stale pnpm overrides (hono, @hono/node-server, path-to-regexp) that no longer resolve to anything in the dependency tree. - Delete docs/managed-integrations-rollout.md — documents a finance/ internal-rollout feature set and env vars that do not exist in the code, plus a broken link; drop its dangling README references. - Merge the 2 unique Edge Config scenarios from managed-integrations.test.mjs into integration-flags.test.mjs (the rest was a duplicate), then delete it. All tests (175), lint, format, and typecheck pass.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A codebase audit to make the repo easier to maintain. This removes dead code and stale artifacts with no behavior change — every deletion was verified to have zero live consumers, and the full test/lint/format/typecheck suite passes.
The codebase is otherwise lean: no unused runtime or dev dependencies, no orphan source modules, no orphan test stubs.
What changed
1. Dead UI primitives (6 files) — shadcn copies in primitives whether or not you use them. This is a self-contained dead cluster with zero inbound references anywhere in
src/ortests/:ui/alert.tsx,ui/empty.tsx,ui/field.tsx,ui/toggle-group.tsx— never importedui/toggle.tsx— imported only bytoggle-group(dead)ui/label.tsx— imported only byfield(dead)2. Stale
pnpm.overrides(3 pins) —hono,@hono/node-server, andpath-to-regexpoverrides no longer resolve to anything in the dependency tree (leftover from a removed Better Auth server stack). The lockfile'soverridesblock is updated to match.3. Stale documentation —
docs/managed-integrations-rollout.mddocumented a finance/internal-rollout feature set and env vars (AGENT_FINANCE_WORKFLOWS_ENABLED, internal-user flags, afinance_datatool) that do not exist in the code, plus a broken link to a non-existent doc. Removed it and its two danglingREADME.mdreferences. (docs/vercel-production-launch-readiness.mdis accurate and kept.)4. Duplicate test —
tests/managed-integrations.test.mjslargely duplicatedtests/integration-flags.test.mjs(same module, same cases) but held 2 unique Edge Config scenarios. Merged those two scenarios intointegration-flags.test.mjs, then deleted the duplicate.Verification
pnpm test— 175 tests pass (including the migrated Edge Config cases)pnpm lint— clean (--max-warnings=0)pnpm format:check— cleanpnpm typecheck— clean928 deletions, 46 insertions across 12 files.
https://claude.ai/code/session_01DuT6P59kvDeYNiVQwPck6C
Generated by Claude Code