fix: address Med-severity findings from the whole-codebase review - #198
Merged
Conversation
The soap decoders cap their input at soap.MaxResponseBytes, but the live path buffers the whole body in transport.doOnce first, so the guard was dead code. The cap now applies at the read; an oversized response fails immediately and is not retried.
Write commands previously printed their success line as plain text
regardless of --output, breaking --output=json scripting. The line now
renders via the shared Render seam wrapped in a writeResult: table
output stays the bare line, json/yaml emit a {"message": ...} object.
update_mailinglist --config-file / --subscriber blobs reached the stderr logfmt line, the --audit-log JSON sink, and the --dry-run preview verbatim; the list config can carry the list password in cleartext. RedactParams now replaces any multi-line or >256-byte value with an <elided N bytes> marker.
Heartbeat blindly re-saved its process's in-memory token with a fresh expiry, overwriting a newer token another process had persisted since. The new session.Store.Refresh extends an entry only while the on-disk token still matches; Save's doc no longer promises what it cannot hold.
The add_mailinglist fault-map key carried a doubled mailinglist_ prefix and matched no fixture; AssertFaultFixtures skips unknown keys silently, so the mailinglist_domain_doesnt_exist code pin never ran.
get_server_information fixtures move from testdata/account/ to their own testdata/server/ per the one-subdir-per-module convention. server and usage gain the previously missing fault leg: a no_auth fault fixture per action (the captured auth fault is action-independent) pinned via testutil.AssertFaultFixtures.
ROADMAP.md listed 'server get'; the shipped command is 'server info'. CHANGELOG.md's [Unreleased] had duplicated, unordered subsections (Changed x3, Fixed x2); they are consolidated into one block per type in canonical Keep-a-Changelog order, plus entries for the Med-severity review fixes.
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nine Med-severity findings from the 2026-07-18 whole-codebase review:
--output(json/yaml emit amessageobject)Store.Refreshand can no longer clobber a newer token from another processmailinglist_domain_doesnt_existpin actually runsget_server_informationfixtures moved totestdata/server/; both modules gain the missing fault-fixture leg +AssertFaultFixturescoverageserver getcorrected toserver info[Unreleased]consolidated to one block per type in canonical Keep-a-Changelog order