fix(cli): address Med/Low findings from the fourth review pass - #201
Merged
Conversation
- elide the update_mailinglist config/subscriber blobs from audit records by key, independent of the multi-line/oversized heuristic - make 'help <nonsense>' exit 1 like every other unknown command - rename the last singular-named fixture to account/get_accounts_response_success_single.xml - document the plain-text output of config show/path/list-profiles and sessions delete (global --output has no effect there) - describe every mail accounts update / ddnsusers update field flag as a replacement value, matching the other update commands - isolate the white-box runWriteE created_id test from host state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the Med + Low findings of the fourth whole-codebase review pass: the
mail lists updateconfig/subscriberblobs are now elided from audit records by key (a single-line config short enough to pass the shape heuristic could previously reach both sinks verbatim, including an embedded cleartext list password);help <nonsense>exits 1 like every other unknown command; the last singular-named fixture was renamed toaccount/get_accounts_response_success_single.xml;config show/path/list-profilesandsessions deletedocument their plain-text output (global--outputhas no effect there); themail accounts update/ddnsusers update--helptexts follow the replacement-value convention; and the white-boxrunWriteEcreated_id test is isolated from host state.