fix: drop doubled action prefix in usage decoder errors - #44
Merged
Conversation
DecodeSpace / DecodeSpaceUsage / DecodeTraffic prefixed inner errors with the KAS action name (`usage: get_space: ReturnInfo[%d] …`). The Client wrappers already wrap with `usage: get_<action>: %w`, so the resulting error string repeated the action twice (`usage: get_space: usage: get_space: …`). Drop the action segment from the decoder messages so they read `usage: …` only, matching the established pattern in the `account` and `server` decoders where the action layer is owned exclusively by the client wrapper. Found in the post-merge review of the usage read-module slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DecodeSpace/DecodeSpaceUsage/DecodeTrafficprefixed inner errors with the action name; the Client wrappers prepend the action layer too, producingusage: get_space: usage: get_space: …. Strip the action segment from decoder messages so they readusage: …only — same pattern asaccount/server.Found during the post-merge review of #43.