feat: accounts get <account-login> via get_accounts filter - #54
Merged
Conversation
Add account.Client.Get(ctx, login) calling get_accounts with an account_login filter; unwrap the single-entry array and surface an empty result as a not-found error, mirroring mailaccount.Client.Get. Rename the existing accounts get (get_accountsettings) to accounts settings so accounts get can take an <account-login> argument. This matches the established mail accounts list|get pattern. Add a singular Tabular layout on Account for the key/value detail view, plus a new singular fixture testdata/account/get_account_response_success.xml derived from the existing list fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kasapi-cli accounts get <account-login>callingget_accountswith anaccount_loginfilter; result is unwrapped from the single-entry array, missing logins surface as a not-found error.kasapi-cli accounts get(=get_accountsettings) renamed toaccounts settings. This frees upgetfor the filter pattern and matchesmail accounts list|get.Account, plus the newtestdata/account/get_account_response_success.xmlfixture.