Fix Slack alerts not firing for declarative pipeline tasks#68
Merged
Fix Slack alerts not firing for declarative pipeline tasks#68
Conversation
The on_failure_callback on DatabricksRunNowOperator was overriding the DAG-level callback (Slack alerts) set in default_args. Build a composite callback that cancels the Databricks run AND invokes the DAG-level alert callback.
siklosid
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatabricksRunNowOperatorinDeclarativePipelineCreatorwas settingon_failure_callback=_cancel_databricks_rundirectly on the operator, which overrides the DAG-levelon_failure_callback(Slack alerts) fromdefault_args_build_failure_callback()that creates a composite callback: cancels the Databricks run and invokes the DAG-level alert callback (e.g. Slack notifications)_cancel_databricks_run)Test plan
datastgand trigger a failure to verify Slack alert fires