Repository navigation
Fix F1 Slither detector registration and raw diagnostics - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The Python API integration imported
slither.detectors.all_detectorsand attemptedlist(all_detectors). In Slither this is a Python module, not an iterable detector list. The fallback import path is not the supported registry either. As a result, the exception path silently produceddetector_list = [], no built-in detectors were registered, andrun_detectors()returned an empty result while F1 was still marked successful. This explains the screenshot'sSlither signals: 0and model finding markedungrounded.Changes
all_detectorsmodule usinginspect.getmembers, retaining concrete subclasses ofAbstractDetector./analyzeresponse metadata for verification.main.py: an emptyfiltered_detectorslist previously fell through to the unfiltered raw detector list due to Python'sorbehavior. The app now respects an explicitly empty filtered set and cannot accidentally bypass its finding filter.Validation
CI will run the full pytest suite. The live Render Reentrancy sample remains the final acceptance check: F1 registry should be non-zero, raw results should include
reentrancy-eth, filtered results should retain it, and the finding should begrounded.This PR does not change detector thresholds or add model-generated findings to Slither results.