Conversation
✅ Deploy Preview for tiny-form-fields ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| else | ||
| text " (optional)" | ||
| span [ class "tff-label-optional" ] [ text " (optional)" ] |
There was a problem hiding this comment.
add a span with class so that the (optional) can remain unbold while the label becomes bold
There was a problem hiding this comment.
Ok. Though the actual bold style should probably be a decision by the app using the lib, instead of the lib itself?
There was a problem hiding this comment.
yes, actually the minimal change i need is just having this span and class, every other thing including the ordering i can do on my side. however, if you think that moving the field description up is a good to have in your library for accessibility sake, then i would say the text looks very cramped using ur original style and this updated styling would suit this new layout much better
ss if i keep ur original styles and just move the field desc up
| System -> | ||
| text "" | ||
| ] | ||
| , viewFormFieldOptionsPreview config fieldID formField |
There was a problem hiding this comment.
moved field description to above the input field
There was a problem hiding this comment.
My understanding is that this reordering by is an accessibility win (speak before the input) but to fully utilise that, we should use aria-describedby to associate the hint with the input
| @apply align-middle; | ||
| } | ||
|
|
||
| .tff-field-group > label.tff-field-label { |
There was a problem hiding this comment.
since checkbox and radiobuttons also use field label, scope down the css selector further by adding .tff-field-group > so that only the titles are affected
2 participants
update styling
(optional)remains unbold|