Repository navigation
Robust Boundary Conditions, Container Healthchecks, and Docker-focused CI Pipeline - #48
Conversation
…used CI pipeline - Catch `ClientDisconnect` during body streaming and file upload and return standard 499 status codes. - Check `request.is_disconnected()` in API endpoints before starting and during synchronous OCR to release resources early. - Configure `NDLOCREngine.shutdown` with `wait=False, cancel_futures=True` to immediately cancel queued threads and support graceful termination under timeouts or OOM. - Add descriptive keywords and description metadata to `pyproject.toml`. - Install `curl` in Dockerfile and configure example downstream service integration via healthchecks in `docker-compose.yml`. - Set up a Docker-focused integration CI workflow in `.github/workflows/ci.yml`. - Write comprehensive test suite in `tests/test_boundary_conditions.py` for client disconnection and graceful shutdown handling. Co-authored-by: chottokun <29515187+chottokun@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
…used CI pipeline - Catch `ClientDisconnect` during body streaming and file upload and return standard 499 status codes. - Check `request.is_disconnected()` in API endpoints before starting and during synchronous OCR to release resources early. - Configure `NDLOCREngine.shutdown` with `wait=False, cancel_futures=True` to immediately cancel queued threads and support graceful termination under timeouts or OOM. - Add descriptive keywords and description metadata to `pyproject.toml`. - Install `curl` in Dockerfile and configure example downstream service integration via healthchecks in `docker-compose.yml`. - Set up a Docker-focused integration CI workflow in `.github/workflows/ci.yml`. - Write comprehensive test suite in `tests/test_boundary_conditions.py` for client disconnection and graceful shutdown handling. Co-authored-by: chottokun <29515187+chottokun@users.noreply.github.com>
…pand boundary condition test suite
1 participant
This submission implements comprehensive race-condition and boundary condition handling for client disconnections and graceful shutdown. It also adds proper container healthchecks, setup-ready docker-compose dependees example, descriptive metadata in pyproject.toml, and a Docker-focused CI pipeline for integration tests on GitHub Actions.
PR created automatically by Jules for task 11816783072604968211 started by @chottokun