Repository navigation
Refactor is_encoder_decoder check in HFTextEncoder - #116
Conversation
- Replace hasattr/truthy check with getattr(self.config, "is_encoder_decoder", False) in src/app/visual_bge/eva_clip/hf_model.py - Remove TODO comment inquiring about is_encoder_decoder attribute - Add unit tests in src/tests/test_hf_model.py covering True, False, and missing attribute cases Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Refactored the is_encoder_decoder attribute check in HFTextEncoder to use getattr safely with a False default and removed the TODO comment. Added comprehensive unit tests in src/tests/test_hf_model.py.
PR created automatically by Jules for task 1881524488814711672 started by @chottokun