Repository navigation
🧪 test: add unit tests for request logging and security headers middlewares - #121
Conversation
…ares - Add test for `RequestLoggingMiddleware` exception handling and `request_id_var` cleanup in `src/tests/test_logger.py` - Add test for `SecurityHeadersMiddleware` injection on 500 error responses in `src/tests/test_security_headers.py` Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…solve merge conflict
1 participant
🧪 [testing improvement] Add test coverage for RequestLoggingMiddleware and SecurityHeadersMiddleware edge cases
🎯 What:
Expanded unit test coverage for
RequestLoggingMiddlewareandSecurityHeadersMiddleware(previously combined asrequest_logging_and_security_headersmiddleware before modularization).📊 Coverage:
RequestLoggingMiddlewarelogs unhandled exceptions with a500status code, path, method, and latency context fields while properly resetting therequest_id_varContextVar upon re-raising exceptions.SecurityHeadersMiddlewarereliably attaches all required HTTP security headers (X-Content-Type-Options,X-Frame-Options,X-XSS-Protection,Strict-Transport-Security,Referrer-Policy,Content-Security-Policy) even on 500 Internal Server Error responses.✨ Result:
Increased codebase reliability by ensuring middleware exception handling, context isolation, and response header injection behave deterministically under failure conditions.
PR created automatically by Jules for task 11615215936253620150 started by @chottokun