Skip to content

🔒 Fix SSRF vulnerability in TEI proxy endpoint path handling - #122

Merged
chottokun merged 3 commits into
mainfrom
fix/ssrf-tei-proxy-10672689314195510687
Oct 12, 2026
Merged

chottokun merged 3 commits into
mainfrom
fix/ssrf-tei-proxy-10672689314195510687

Conversation

@chottokun

Copy link
Copy Markdown
Owner

🎯 What: The _proxy_to_tei helper in src/app/dependencies/services.py now enforces an explicit whitelist (ALLOWED_TEI_PATHS = {"/v1/embeddings", "/rerank", "/predict", "/embed"}) before appending paths to tei_url.

⚠️ Risk: Previously, unvalidated path arguments passed to _proxy_to_tei allowed potential Server-Side Request Forgery (SSRF) or arbitrary internal endpoint targeting on the TEI server instance.

🛡️ Solution: Validates that path is in ALLOWED_TEI_PATHS, raising HTTP 400 if invalid, and safely formats the target URL using tei_url.rstrip('/'). Comprehensive unit tests were added to src/tests/test_tei_proxy.py.


PR created automatically by Jules for task 10672689314195510687 started by @chottokun

Validate requested paths in _proxy_to_tei against an explicit allowlist
(ALLOWED_TEI_PATHS) to prevent SSRF and unauthorized endpoint invocation.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chottokun
chottokun merged commit cac2b99 into main Oct 12, 2026
2 checks passed
@chottokun
chottokun deleted the fix/ssrf-tei-proxy-10672689314195510687 branch October 12, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant