Remove incorrect double-encoding of ImageUrl#3
Open
andersk wants to merge 2 commits intochowdhurya:masterfrom
Open
Remove incorrect double-encoding of ImageUrl#3andersk wants to merge 2 commits intochowdhurya:masterfrom
ImageUrl#3andersk wants to merge 2 commits intochowdhurya:masterfrom
Conversation
The url::UrlQuery API already takes care of encoding. This extra encoding step resulted in an incorrect double-encoding of `url?` to `d=url%253F` rather than the correct `d=url%3F`. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
url::UrlQueryAPI already takes care of encoding. This extra encoding step resulted in an incorrect double-encoding ofurl?tod=url%253Frather than the correctd=url%3F.