Repository navigation
fix(deps): declare jsonschema as a runtime dependency - #548
Merged
Merged
Conversation
server/tools.py imports jsonschema to validate lean_verify's result against the schema it advertises, but no runtime dependency declared it. It installed only because mcp requires it. The contract extra, which #547 removes, was the one place it was ever named. Declare it explicitly, at the >=4.20 floor mcp already requires, as the project does for jinja2 and python-multipart. uv.lock gains only the jsonschema lines; `uv lock --check` passes.
#547 removed the contract extra, whose jsonschema entry sat next to the runtime one this branch adds. uv.lock keeps the runtime requirement and drops the contract one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
server/tools.pyimportsjsonschemaat module load, to validatelean_verify's result against the schema the tool advertises. No runtime dependency declared it; it installed only becausemcprequires it. Thecontractextra, which #547 removed, was the one place it was ever named.This declares it explicitly at the
>=4.20floormcpalready requires, with the same kind of commentpyproject.tomlgivesjinja2andpython-multipart("already a transitive dep via mcp; declared explicitly"). This is the runtime counterpart of what #377 did forhttpxin the dev group.Verification
uv.lockgains only the twojsonschemalines: the requirement and its specifier. A full re-lock with this sandbox's uv also rewrote somenvidia-*platform markers; that churn is left out.uv lock --checkpasses.jsonschema4.26.0.tests/test_wheel_packaging.pyandtests/test_dev_toolchain_guard.pypass, andruff check .is clean.mainatd1906ba(after Remove release pins and the formal-contract tooling #547 and feat(tools): build definitions during notebook ingest #549), this branch merged with fix(server): resource links that resolve, theorem index kept intact #552 and the full suite run gives 5680 tests and 1 failure. That failure istest_symlink_loop_is_rejected, which fails in the cloud sandbox for a reason unrelated to this change.Notes
mainafter Remove release pins and the formal-contract tooling #547 (7afff9d). Remove release pins and the formal-contract tooling #547's removal of thecontractextra conflicted inuv.lockwith the runtimejsonschemaline this adds, since the two entries were adjacent. The resolution keeps the runtime requirement and drops the contract one. The diff againstmainis now exactly thepyproject.tomlentry plus those two lock lines.