Repository navigation
feat(server): keep theorem-name index in its dataset - #556
Merged
Merged
Conversation
The theorem-name index lived at index/sqlite/theorem_names.db, beside the dataset rather than in it, so every notebook-routed server read the shared corpus's names, notebook ingest never built one, and a cutover or rollback swapped the chunks but left the index behind. The index now lives at <lancedb>/derived/theorem_names.db. LanceDB ignores the extra directory, so the existing renames carry the index with its chunks. Config and ApplicationPaths derive the path from the dataset unless ARXMCP_THEOREM_NAMES_DB_PATH is set, notebook ingest builds it, and the backup-set checkpoint includes the shared copy. Upgrade: an existing index/sqlite/theorem_names.db is no longer read. find_lemma_by_name takes in_memory_scan_fallback until python -m ingest.index_theorem_names is re-run. Closes #553
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the theorem-name index from
index/sqlite/theorem_names.dbto<lancedb>/derived/theorem_names.db, so cutover and rollback carry it with its chunks. Each notebook now reads its own index, and notebook ingest builds it. This is phase 1 of #551.Closes #553
Verification
ruff check .is clean.mainand pass here:pyteston Linux has 1 failure,test_symlink_loop_is_rejected. It fails onmaintoo: Python 3.13'sPath.resolve()no longer raises on symlink loops.Notes
index/sqlite/theorem_names.dbis no longer read.find_lemma_by_nametakesin_memory_scan_fallbackuntilpython -m ingest.index_theorem_namesis re-run.ARXMCP_THEOREM_NAMES_DB_PATHstill overrides the path.derived/bm25, then #551 phase 3: build derived indexes into staging before cutover #555 builds the indexes into staging.Generated by Claude Code