Feature request to pass HTTP_ORIGIN with CORS

[caseman72]

Chris,

I added the feature. The issue with the response it that you don't have the request object:
http://sysmagazine.com/posts/166539/

So I did the following:

• wrapped the background.js in a method - to avoid global scope (this reduces warnings by ugilfyjs)
• added a requestIds array / stack that caches the request data. I allow 10s before the request is GC'd
• added a onBeforeSendHeaders handler - to find the request data
• moved the onErrorOccurred to onErrorOccurredHandler to continue with the same logic and not stack the event handler on every change
• added the logic to change HTTP_ORIGIN to "Origin/Referer/*" in that order
• tested it with my garmin.com.js plugin - works great!!

[chrisdeely]

I'd recommend using an object hash instead of an array here. That way we won't need to iterate/filter the array later, we can just pull out the request by its ID:

requestIds = {};
requestIds[ 'ID_'+info.requestId ] = { origin: origin, expiration:1234 };

//when retrieving value
var request = requestIds[ 'ID_' + info.requestId ];

[caseman72]

I started with a hash - but then you'd have to use delete() to remove items. Since the list isn't every going to be huge the looping speed will be small. Using an array - you can use the Array methods like '.find' and '.filter' ...

I don't like to remove items in a loop like this:

for (var id in hash) {
    delete(hash[id]);
}

[chrisdeely]

There's no need to loop through the IDs, you'll have the specific ID you need to delete:

delete requestIds[ 'ID_' + info.requestId ];
//or if you don't care about having an empty key
requestIds[ 'ID_' + info.requestId ] = null;

I don't see any situation in the code where you would iterate all of the keys...

[caseman72]

How about when you have a request but no response? Your requestIds will grow ...

[caseman72]

You would have to loop through the Object - looking for expired (non-response) - so since the list will be at most 100 (100 requests in 10s) - looping isn't a big deal ... using a hash seems like a good idea until you do for (var id in hash) - then looping is better in an array.

[chrisdeely]

valid point, the request should be removed from the requestIds inside the getRequestAndCleanUp method then.

Did you intend to periodically clean out 'expired' requests? I don't see that logic here

[caseman72]

    requestIds = requestIds.filter(function(elem) {
        if (elem.requestId === requestId) {
            request = elem;
        }
        return (elem.expiration < now && elem.requestId !== requestId);
    });

This will find the element and filter expired ones and the current one ...

This may be better (less compares):

    requestIds = requestIds.filter(function(elem) {
        if (elem.requestId === requestId) {
            request = elem;
            return false; // remove
        }
        return (elem.expiration < now); // true -keep- if not expired
    });

[caseman72]

Thanks! I found a bug with my filter... updating code now.

Logic was ok ... filter is weird as it true (keeps) and false (removes)