Share _signature_cache with uncalled-for#357
Merged
chrisguidry merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
`docket.execution` had its own `_signature_cache` dict, separate from the
one in `uncalled_for.introspection`. FastMCP clears
`docket.execution._signature_cache` after mutating function signatures
(via `transform_context_annotations`), but `get_dependency_parameters`
reads from uncalled-for's cache — so the stale entry stuck around and
dependency resolution silently returned `{}`.
Now both `_signature_cache` and `_parameter_cache` are re-exported from
uncalled-for, so there's one shared dict for each.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 108 108
Lines 3159 3163 +4
Branches 26 26
=========================================
+ Hits 3159 3163 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docket.executionhad its own_signature_cachedict, separate from the one inuncalled_for.introspection. FastMCP clearsdocket.execution._signature_cacheafter mutating function signatures (viatransform_context_annotations), butget_dependency_parametersreads from uncalled-for's copy — so the stale entry stuck around and dependency resolution silently returned{}.Now both
_signature_cacheand_parameter_cacheare re-exported from uncalled-for, so there's one shared dict for each. Added contract tests asserting cache identity.🤖 Generated with Claude Code