Skip to content

fix(inference): clamp dense walk top-k to feature count #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
citizenu03bb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(inference): clamp dense walk top-k to feature count #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion crates/larql-inference/src/vindex/walk_ffn/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,9 @@ fn walk_trace_env_enabled() -> bool {

impl<'a> WalkFfn<'a> {
fn top_k_for(&self, layer: usize) -> usize {
self.config.k_for(layer).unwrap_or(usize::MAX)
self.config
.k_for(layer)
.unwrap_or_else(|| self.index.num_features(layer))
}

// ── Legacy constructors (stable public API) ──
Expand Down Expand Up @@ -786,6 +788,15 @@ mod dispatch_tests {
assert_eq!(out.shape(), &[1, weights.hidden_size]);
}

#[test]
fn dense_top_k_for_clamps_to_layer_feature_count() {
let weights = shared_weights();
let idx = mock_index(weights);
let ffn = WalkFfn::new_unlimited(weights, &idx);

assert_eq!(ffn.top_k_for(0), weights.intermediate_size);
}

/// Variant of `MockGateIndex` that yields a `FeatureMeta` for every
/// `(layer, feature)` query. This is what `take_trace` needs to
/// promote a residual into a populated `WalkHit` — without it, the
Expand Down