fix(cli): build_cmd should respect vindex dtype when saving gate vectors - #201
Open
17skills wants to merge 1 commit into
Open
fix(cli): build_cmd should respect vindex dtype when saving gate vectors#20117skills wants to merge 1 commit into
17skills wants to merge 1 commit into
Conversation
larql build calls save_gate_vectors(&output_dir), which hardcodes F32 output regardless of the vindex dtype in the build config. Route the CLI through the existing config-aware save_gate_vectors_with_config() so an f16 vindex gets f16 gate vectors instead of silently doubling their size on disk and diverging from the declared dtype.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
larql buildcurrently callssave_gate_vectors(&output_dir), which hardcodes F32 output regardless of the vindex dtype in the build config.save_gate_vectors_with_config()already exists (and is covered bysave_gate_vectors_with_config_preserves_expert_geometryincrates/larql-vindex/src/index/mutate/tests.rs), but the CLI call site never adopted it — so an f16 vindex silently gets F32 gate vectors, doubling their size on disk and diverging from the declared dtype.One-line change: route the CLI through the config-aware variant. Rebases cleanly onto current
main.