Open
Conversation
Collaborator
|
Thanks for taking a stab at this! Before merging, this will need to have some tests to go along with it. I can try to review this when I have some time, but I can't guarantee when that will be. For now, if you need a quick fix in your app and you're not already doing so, so can simply copy over your modified |
Contributor
Author
|
I didn't see any JS testing being done for the gem. Is it in the dummy rails app somewhere? The fix ended up being really minor. Basically using jquery's |
Contributor
Author
|
What's the plan for 2.0? Seems far off. Is there anything you are waiting on from me to get this merged in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180