Repository navigation
Show who answered a question dialog in t3_thread_read - #136
Merged
chrisohearn merged 1 commit intoNov 16, 2026
Merged
Conversation
The server already stamps answeredBy and answeringClient on an answered user_input_request item, but the MCP timeline dropped them and returned createdBy and creationSource null, so a reader could not tell an owner's answer from an agent's. Pass both through on the timeline item. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
chrisohearn
merged commit Nov 16, 2026
78f183a
into
integration/mcp-events-20261109
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
t3_thread_readnow returnsansweredByand, for an owner answer,answeringClienton an answered question dialog (user_input_request).Why
The server already records who answered a dialog (
questionAnswer.answeredBy:owner_client,mcp_clientoragent), but the MCP timeline item dropped it. A dialog is not a message, socreatedByandcreationSourceare null, and a coordinator reading the thread could not tell the owner's own answer from one an agent gave. It then had to discard the answer and ask again.Change
packages/contracts/src/orchestratorMcp.ts: two optional fields onOrchestratorMcpThreadTimelineItem.apps/server/src/mcp/OrchestratorMcpService.ts:timelineItempasses them through, following thesenderClientpattern.t3_thread_read.Read-only output of data the server already stores. No migration, no new tool, no description change. Answers and quotes are not exposed.
Proof
readThread shows who answered a question dialog(owner, agent, legacy answer, pending).pnpm typecheck, lint,apps/serverMCP tests andpackages/contractstests pass locally.🤖 Generated with Claude Code