Skip to content

Show who answered a question dialog in t3_thread_read - #136

Merged
chrisohearn merged 1 commit into
integration/mcp-events-20261109from
feat/dialog-answer-provenance
Nov 16, 2026
Merged

chrisohearn merged 1 commit into
integration/mcp-events-20261109from
feat/dialog-answer-provenance

Conversation

@chrisohearn

Copy link
Copy Markdown
Owner

What

t3_thread_read now returns answeredBy and, for an owner answer, answeringClient on an answered question dialog (user_input_request).

Why

The server already records who answered a dialog (questionAnswer.answeredBy: owner_client, mcp_client or agent), but the MCP timeline item dropped it. A dialog is not a message, so createdBy and creationSource are null, and a coordinator reading the thread could not tell the owner's own answer from one an agent gave. It then had to discard the answer and ask again.

Change

  • packages/contracts/src/orchestratorMcp.ts: two optional fields on OrchestratorMcpThreadTimelineItem.
  • apps/server/src/mcp/OrchestratorMcpService.ts: timelineItem passes them through, following the senderClient pattern.
  • Docs: one paragraph under t3_thread_read.

Read-only output of data the server already stores. No migration, no new tool, no description change. Answers and quotes are not exposed.

Proof

  • New test readThread shows who answered a question dialog (owner, agent, legacy answer, pending).
  • pnpm typecheck, lint, apps/server MCP tests and packages/contracts tests pass locally.

🤖 Generated with Claude Code

The server already stamps answeredBy and answeringClient on an answered
user_input_request item, but the MCP timeline dropped them and returned
createdBy and creationSource null, so a reader could not tell an owner's
answer from an agent's. Pass both through on the timeline item.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T18:31:35.135661Z 93d6f1c PR opened
🔒 Security Review ✅ Completed 2026-11-16T18:34:14.765597Z 93d6f1c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chrisohearn
chrisohearn merged commit 78f183a into integration/mcp-events-20261109 Nov 16, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants