Repository navigation
Merge upstream stable v0.1.10 - #140
Conversation
Co-authored-by: bentbrain <28818884+bentbrain@users.noreply.github.com>
…tgg#30753) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>
…gdotgg#29749) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
… reply (pingdotgg#30084) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#32376) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…on every host (pingdotgg#32774) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: GPT-6.1 Sol <noreply@openai.com> Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…failed when one did (pingdotgg#32407) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ted (pingdotgg#32413) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#32323) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…s cancelled (pingdotgg#32414) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#33083) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ing node_modules (2,500 s → 5.0 s) (pingdotgg#32023) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…iew (pingdotgg#32324) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…y never show (pingdotgg#32351) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#32364) Co-authored-by: azhar <azhar.amir@amartha.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…33069) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#32598) Co-authored-by: Zuri <zurih@rtx.internal> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…d player item (pingdotgg#32196) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#33078) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#32657) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#32619) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ad read instead of hiding its threads (pingdotgg#32620) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#32683) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ead (pingdotgg#37735) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…s as a silent success (pingdotgg#37738)
…ingdotgg#37733) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#37741) Co-authored-by: Usama Khan <usama@Usamas-MacBook-Pro.local> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts: # apps/server/src/mcp/McpHttpServer.ts # apps/server/src/mcp/OrchestratorMcpService.test.ts # apps/server/src/mcp/OrchestratorMcpService.ts # apps/server/src/mcp/toolkits/project/handlers.test.ts # apps/server/src/mcp/toolkits/thread/handlers.ts # apps/server/src/mcp/toolkits/thread/tools.ts # apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts # apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts # apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts # apps/server/src/orchestration-v2/Orchestrator.ts # apps/server/src/orchestration-v2/ProjectionStore.ts # apps/server/src/orchestration-v2/ProviderRuntimeRecoveryService.test.ts # apps/server/src/orchestration-v2/ProviderRuntimeRecoveryService.ts # apps/server/src/orchestration-v2/ProviderSessionManager.ts # apps/server/src/orchestration-v2/RunExecutionService.test.ts # apps/server/src/orchestration-v2/runtimeLayer.test.ts # apps/server/src/peer/PeerForwarding.test.ts # apps/server/src/peer/PeerForwarding.ts # apps/server/src/persistence/Migrations.ts # apps/server/src/provider/agentContextBudget.json # apps/server/src/scheduledTasks/ScheduledTaskService.test.ts # apps/server/src/scheduledTasks/ScheduledTaskService.ts # apps/server/src/workspace/WorkspaceSearchIndex.test.ts # apps/server/src/workspace/WorkspaceSearchIndex.ts # packages/provider-core/src/server/ProviderAdapter.ts
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Review of record: fallback source review (hosted review hit its usage limit)Disposition: CHANGES REQUESTED. Not approved; actionable findings below.
Scope checked. I line-reviewed the merge resolution of Findings1. P1: thread deletion removes an attachment file that a live fork still shows (data loss).
2. P2:
3. P3:
4. P3: the repair dropped fork-history validation from normal startup.
5. P3: the merge commit carries undisclosed fork-only rewrites of upstream-owned paths (FORK.md: keep fork changes small, in fork-only files).
Per the engineering finding rules, P2 and P3 items can become linked issues. Finding 1 needs a fix and a re-review of the repaired head before this merges. |
|
@codex security review |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
Candidate repair update: 93ba9bf restores attachment retention while a surviving live fork still shows the attachment. The existing regression case now verifies the bytes remain until the last displaying fork is deleted. Local proof passed: focused attachment/fork tests, check:changed (41/41 tasks; 4,248 tests across 156 files), and commit hooks. A fresh exact-head source review is in progress; the P1 finding remains pending that review. Follow-up issues for the other findings:
The hosted Security review has been requested for this head. The existing merge, publication, deployment, live reconciliation, installation, and adoption holds remain in force. |
Independent source review (review of record): PR #140Bound to: base Scope
Attachment lifecycle fix (
|
|
Review of record: fallback source review for base The hosted review bots failed on quota or allowance, so this is the required fallback: an independent, read-only review by Claude Opus. FORK.md was read from the base ref. Before posting I confirmed that the PR's head is exactly Verdict: no blocking findings. The three earlier findings are fixed. One P3 test-coverage finding is listed below; it does not block the merge. Earlier findings
Other checks
Findings
The fallback reviewer has no approval role here, so this review neither approves nor merges the PR. |
|
Review of record: fallback source re-review for base The hosted review bots are quota-limited and were not re-requested, so this is the fallback review: a fresh, independent, read-only review by Claude Opus. I read FORK.md from the base ref. Before posting, I confirmed that the PR still targets Verdict: no findings remain. The P3 coverage finding from the previous review is fixed, and the three earlier findings are still fixed. When I posted, 15 hosted checks on this head had passed, none had failed, and Test, Test Server 6, Test Web 2 were still running. New delta (
|
|
Upstream sync: merges Format, lint, typecheck, server tests, the container release build with its smoke test, and the service preflight against the live database passed. Prepared release candidate 🤖 Generated with Claude Code |
7ab0382
into
integration/mcp-events-20261109
Integrates upstream stable
v0.1.10(7d32075e3757ded707914e2450c3e392a9665765) and repairs the candidate's migration startup behavior and tests required by the merged upstream tree.check:changed: format, lint, knip, GraphQL, 41-package typecheck, 156 test files (4,248 tests), and React Compiler.t3_fork_migrations.Model/harness: GPT-6.2 Codex via T3.