Repository navigation
fix(server): keep Codex shadow memories private - #147
Open
chrisohearn wants to merge 4 commits into
Open
chrisohearn wants to merge 4 commits into
chrisohearn wants to merge 4 commits into
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex CLI 0.170 creates
memories_v2in the shared home while each shadow may retain its own real directory. Older setup treated a real shadow directory as a conflict and left legacy links to shared memories in place.This change:
memories_v2as shadow-local and preserves real shadow data;memories_v2as auto-settle, then removes only the link while preserving its target;Closes #146
Validation:
vp test run apps/server/src/provider/Drivers/CodexHomeLayout.test.ts— 23/23 passed.bash scripts/fork/host/t3-update-guard/test-guard.sh— passed.vp run check:changed origin/integration/mcp-events-20261109— all steps passed (4 changed files; 25 tests across 2 files).🤖 Generated with GPT-6 Luna in T3 Code.