Skip to content

fix(server): keep Codex shadow memories private - #147

Open
chrisohearn wants to merge 4 commits into
integration/mcp-events-20261109from
sync/upstream-20261119-memories-v2
Open

chrisohearn wants to merge 4 commits into
integration/mcp-events-20261109from
sync/upstream-20261119-memories-v2

Conversation

@chrisohearn

@chrisohearn chrisohearn commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Codex CLI 0.170 creates memories_v2 in the shared home while each shadow may retain its own real directory. Older setup treated a real shadow directory as a conflict and left legacy links to shared memories in place.

This change:

  • treats memories_v2 as shadow-local and preserves real shadow data;
  • reports legacy links to shared memories_v2 as auto-settle, then removes only the link while preserving its target;
  • prevents rollback to a build whose preflight reports unready or unknown Codex shadow homes.

Closes #146

Validation:

  • Regression tests reproduce both reported cases.
  • vp test run apps/server/src/provider/Drivers/CodexHomeLayout.test.ts — 23/23 passed.
  • bash scripts/fork/host/t3-update-guard/test-guard.sh — passed.
  • vp run check:changed origin/integration/mcp-events-20261109 — all steps passed (4 changed files; 25 tests across 2 files).
  • No migration files or ids changed.

🤖 Generated with GPT-6 Luna in T3 Code.

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-19T18:47:24.916750Z
We couldn’t complete this review. Comment @codex review to try again.
7b44017 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants